Assert AR table entry stability on replace

sferik · sferik · commit 5b1aff369684 · 2025-06-25T16:02:21.000-07:00
diff --git a/hash.c b/hash.c
@@ -880,10 +880,11 @@ ar_general_foreach(VALUE hash, st_foreach_check_callback_func *func, st_update_c
                 return 0;
               case ST_REPLACE:
                 if (replace) {
+                    ar_table_pair *orig_pair = pair;
                     (*replace)(&key, &val, arg, TRUE);
 
-                    // TODO: pair should be same as pair before.
                     pair = RHASH_AR_TABLE_REF(hash, i);
+                    HASH_ASSERT(orig_pair == pair);
                     pair->key = (VALUE)key;
                     pair->val = (VALUE)val;
                 }
