From eedae55b0ad09996b91c27b53b8252a4f111b09a Mon Sep 17 00:00:00 2001 From: Benoit Daloze Date: Fri, 18 Apr 2025 18:51:02 +0800 Subject: [PATCH 1/5] Make it clear not all combinations are supported --- README.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index b0eba4cb8..8a66eb4fb 100644 --- a/README.md +++ b/README.md @@ -53,15 +53,17 @@ The action works on these [GitHub-hosted runners](https://docs.github.com/en/act | macOS | `macos-13` and newer versions | | Windows | `windows-2019`, `windows-2022` | +Not all combinations of runner image and versions are supported. +The list of available Ruby versions per runner image can be seen in [ruby-builder-versions.json](ruby-builder-versions.json) for Ubuntu and macOS +(although some combinations are not available, see [the full list](https://github.com/ruby/ruby-builder/releases/tag/toolcache)) +and in [windows-versions.json](windows-versions.json) for Windows. + The prebuilt releases are generated by [ruby-builder](https://github.com/ruby/ruby-builder) and on Windows by [RubyInstaller2](https://github.com/oneclick/rubyinstaller2). The `mingw`, `ucrt` and `mswin` builds are generated by [ruby-loco](https://github.com/MSP-Greg/ruby-loco). `ruby-head` is generated by [ruby-dev-builder](https://github.com/ruby/ruby-dev-builder), `jruby-head` is generated by [jruby-dev-builder](https://github.com/ruby/jruby-dev-builder), `truffleruby-head` and `truffleruby+graalvm-head` are generated by [truffleruby-dev-builder](https://github.com/ruby/truffleruby-dev-builder). -The full list of available Ruby versions can be seen in [ruby-builder-versions.json](ruby-builder-versions.json) for Ubuntu and macOS -(although some combinations are not available, see [the full list](https://github.com/ruby/ruby-builder/releases/tag/toolcache)) -and in [windows-versions.json](windows-versions.json) for Windows. ## Usage From bcde69c47cdb20b0cfd224b38aaca0d96e17d442 Mon Sep 17 00:00:00 2001 From: Benoit Daloze Date: Fri, 18 Apr 2025 18:54:39 +0800 Subject: [PATCH 2/5] Update README.md --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 8a66eb4fb..91c1b7817 100644 --- a/README.md +++ b/README.md @@ -53,8 +53,8 @@ The action works on these [GitHub-hosted runners](https://docs.github.com/en/act | macOS | `macos-13` and newer versions | | Windows | `windows-2019`, `windows-2022` | -Not all combinations of runner image and versions are supported. -The list of available Ruby versions per runner image can be seen in [ruby-builder-versions.json](ruby-builder-versions.json) for Ubuntu and macOS +Not all combinations of runner images and versions are supported. +The list of available Ruby versions can be seen in [ruby-builder-versions.json](ruby-builder-versions.json) for Ubuntu and macOS (although some combinations are not available, see [the full list](https://github.com/ruby/ruby-builder/releases/tag/toolcache)) and in [windows-versions.json](windows-versions.json) for Windows. From bc1d55035408f952197975f3e98d59efe727f324 Mon Sep 17 00:00:00 2001 From: Benoit Daloze Date: Thu, 24 Apr 2025 13:55:27 +0200 Subject: [PATCH 3/5] Update testFixedBundlerVersionForOldRuby to 2.3 since 2.2 is known to be broken with recent C compilers * See https://github.com/ruby/setup-ruby/issues/496 --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 21a833ebf..3e16d1346 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -291,7 +291,7 @@ jobs: - uses: actions/checkout@v4 - uses: ./ with: - ruby-version: '2.2' + ruby-version: '2.3' bundler: 1.16.6 - run: bundle --version | grep -F "1.16.6" # And not 1.17.x from ~> 1 From 72002957a7e528e38a7473e076f78987da1977df Mon Sep 17 00:00:00 2001 From: Benoit Daloze Date: Thu, 24 Apr 2025 16:25:50 +0200 Subject: [PATCH 4/5] Update to Rails 7.2 and 8 in tests * Rails <= 6 has a known issue with logger and the workaround causes CI failures: https://github.com/ruby/setup-ruby/actions/runs/14641011806/job/41083255632 --- .github/workflows/test.yml | 6 ++---- gemfiles/{rails5.gemfile => rails7.gemfile} | 2 +- gemfiles/{rails6.gemfile => rails8.gemfile} | 2 +- 3 files changed, 4 insertions(+), 6 deletions(-) rename gemfiles/{rails5.gemfile => rails7.gemfile} (56%) rename gemfiles/{rails6.gemfile => rails8.gemfile} (56%) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3e16d1346..fb24aea83 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -369,7 +369,7 @@ jobs: strategy: fail-fast: false matrix: - gemfile: [ rails5, rails6 ] + gemfile: [ rails7, rails8 ] name: "Test with ${{ matrix.gemfile }} gemfile" runs-on: ubuntu-latest env: @@ -378,11 +378,9 @@ jobs: - uses: actions/checkout@v4 - uses: ./ with: - ruby-version: '2.6' + ruby-version: '3.2' bundler-cache: true - run: bundle exec rails --version - env: - RUBYOPT: '-rlogger' # Rails 6 is missing a require 'logger' in active_support/logger_thread_safe_level.rb testTruffleRubyNokogiri: name: "Test installing a Gemfile with nokogiri on TruffleRuby" diff --git a/gemfiles/rails5.gemfile b/gemfiles/rails7.gemfile similarity index 56% rename from gemfiles/rails5.gemfile rename to gemfiles/rails7.gemfile index 199d28a21..73609d5b3 100644 --- a/gemfiles/rails5.gemfile +++ b/gemfiles/rails7.gemfile @@ -1,3 +1,3 @@ source "https://rubygems.org" -gem "rails", "~> 5.2.0" +gem "rails", "~> 7.2.0" diff --git a/gemfiles/rails6.gemfile b/gemfiles/rails8.gemfile similarity index 56% rename from gemfiles/rails6.gemfile rename to gemfiles/rails8.gemfile index b55405ccd..c6318c4f5 100644 --- a/gemfiles/rails6.gemfile +++ b/gemfiles/rails8.gemfile @@ -1,3 +1,3 @@ source "https://rubygems.org" -gem "rails", "~> 6.0.0" +gem "rails", "~> 8.0.0" From 2e007403fc1ec238429ecaa57af6f22f019cc135 Mon Sep 17 00:00:00 2001 From: Benoit Daloze Date: Thu, 24 Apr 2025 20:45:25 +0200 Subject: [PATCH 5/5] Remove support for ubuntu-20.04 * It's gone: https://github.com/actions/runner-images/issues/11101 --- README.md | 2 +- common.js | 1 - dist/index.js | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/README.md b/README.md index 91c1b7817..eddf0d67e 100644 --- a/README.md +++ b/README.md @@ -49,7 +49,7 @@ The action works on these [GitHub-hosted runners](https://docs.github.com/en/act | Operating System | Supported | | ---------------- | --------- | -| Ubuntu | `ubuntu-20.04`, `ubuntu-22.04`, `ubuntu-24.04`, `ubuntu-22.04-arm`, `ubuntu-24.04-arm` | +| Ubuntu | `ubuntu-22.04`, `ubuntu-24.04`, `ubuntu-22.04-arm`, `ubuntu-24.04-arm` | | macOS | `macos-13` and newer versions | | Windows | `windows-2019`, `windows-2022` | diff --git a/common.js b/common.js index e5730c1f6..12932cdd2 100644 --- a/common.js +++ b/common.js @@ -171,7 +171,6 @@ export async function hashFile(file) { // macos is not listed explicitly, see below const GitHubHostedPlatforms = [ - 'ubuntu-20.04-x64', 'ubuntu-22.04-x64', 'ubuntu-22.04-arm64', 'ubuntu-24.04-x64', diff --git a/dist/index.js b/dist/index.js index da47e6da0..093b3ac3a 100644 --- a/dist/index.js +++ b/dist/index.js @@ -491,7 +491,6 @@ async function hashFile(file) { // macos is not listed explicitly, see below const GitHubHostedPlatforms = [ - 'ubuntu-20.04-x64', 'ubuntu-22.04-x64', 'ubuntu-22.04-arm64', 'ubuntu-24.04-x64', pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy