Use Regexp#match? to avoid extra allocations

stevenharman · stevenharman · commit 158f58a9cc7a · 2020-08-18T13:49:08.000-04:00
`#=~` builds `MatchData`, requiring extra allocations as compared to
`#match?`, which returns a boolean w/o having to build the `MatchData`.
diff --git a/lib/uri/common.rb b/lib/uri/common.rb
@@ -397,7 +397,7 @@ def self.encode_www_form_component(str, enc=nil)
   #
   # See URI.encode_www_form_component, URI.decode_www_form.
   def self.decode_www_form_component(str, enc=Encoding::UTF_8)
-    raise ArgumentError, "invalid %-encoding (#{str})" if /%(?!\h\h)/ =~ str
+    raise ArgumentError, "invalid %-encoding (#{str})" if /%(?!\h\h)/.match?(str)
     str.b.gsub(/\+|%\h\h/, TBLDECWWWCOMP_).force_encoding(enc)
   end
 

Original file line number	Diff line number	Diff line change
`@@ -397,7 +397,7 @@ def self.encode_www_form_component(str, enc=nil)`
`397`	`397`	`#`
`398`	`398`	`# See URI.encode_www_form_component, URI.decode_www_form.`
`399`	`399`	`def self.decode_www_form_component(str, enc=Encoding::UTF_8)`
`400`		`- raise ArgumentError, "invalid %-encoding (#{str})" if /%(?!\h\h)/ =~ str`
	`400`	`+ raise ArgumentError, "invalid %-encoding (#{str})" if /%(?!\h\h)/.match?(str)`
`401`	`401`	`str.b.gsub(/\+\|%\h\h/, TBLDECWWWCOMP_).force_encoding(enc)`
`402`	`402`	`end`
`403`	`403`