feat: set the locale to en_US.UTF-8 for git commands

jcouball · jcouball · commit f407b92d14a5 · 2025-02-27T17:25:19.000-08:00
diff --git a/lib/git/lib.rb b/lib/git/lib.rb
@@ -1548,6 +1548,7 @@ def env_overrides
         'GIT_WORK_TREE' => @git_work_dir,
         'GIT_INDEX_FILE' => @git_index_file,
         'GIT_SSH' => Git::Base.config.git_ssh,
+        'LC_ALL' => 'en_US.UTF-8'
       }
     end
 
diff --git a/tests/units/test_command_line_env_overrides.rb b/tests/units/test_command_line_env_overrides.rb
@@ -12,7 +12,8 @@ class TestCommandLineEnvOverrides < Test::Unit::TestCase
         'GIT_DIR' => git.lib.git_dir,
         'GIT_INDEX_FILE' => git.lib.git_index_file,
         'GIT_SSH' => nil,
-        'GIT_WORK_TREE' => git.lib.git_work_dir
+        'GIT_WORK_TREE' => git.lib.git_work_dir,
+        'LC_ALL' => 'en_US.UTF-8'
       }
       expected_command_line = [expected_env, 'checkout', {}]
 
@@ -29,16 +30,15 @@ class TestCommandLineEnvOverrides < Test::Unit::TestCase
       Git::Base.config.git_ssh = 'ssh -i /path/to/key'
 
       assert_command_line_eq(expected_command_line_proc, include_env: true) do |git|
-        # Set the expected command line
-
         expected_env = {
           'GIT_DIR' => git.lib.git_dir,
           'GIT_INDEX_FILE' => git.lib.git_index_file,
           'GIT_SSH' => 'ssh -i /path/to/key',
-          'GIT_WORK_TREE' => git.lib.git_work_dir
+          'GIT_WORK_TREE' => git.lib.git_work_dir,
+          'LC_ALL' => 'en_US.UTF-8'
         }
-
         expected_command_line = [expected_env, 'checkout', {}]
+
         git.checkout
       end
     ensure

Original file line number	Diff line number	Diff line change
`@@ -1548,6 +1548,7 @@ def env_overrides`
`1548`	`1548`	`'GIT_WORK_TREE' => @git_work_dir,`
`1549`	`1549`	`'GIT_INDEX_FILE' => @git_index_file,`
`1550`	`1550`	`'GIT_SSH' => Git::Base.config.git_ssh,`
	`1551`	`+ 'LC_ALL' => 'en_US.UTF-8'`
`1551`	`1552`	`}`
`1552`	`1553`	`end`
`1553`	`1554`