Restore remove_index to DataOwned

akern40 · akern40 · commit 945f70de8138 · 2024-10-26T11:34:25.000-04:00
I think I accidentally moved this over to ArrayRef, but we're not sure it should still require DataOwned
diff --git a/src/impl_methods.rs b/src/impl_methods.rs
@@ -3102,7 +3102,13 @@ impl<A, D: Dimension> ArrayRef<A, D>
             Zip::from(self.lanes_mut(axis)).map_collect(mapping)
         }
     }
+}
 
+impl<A, S, D> ArrayBase<S, D>
+where
+    S: DataOwned<Elem = A> + DataMut,
+    D: Dimension,
+{
     /// Remove the `index`th elements along `axis` and shift down elements from higher indexes.
     ///
     /// Note that this "removes" the elements by swapping them around to the end of the axis and
@@ -3115,7 +3121,6 @@ impl<A, D: Dimension> ArrayRef<A, D>
     /// ***Panics*** if `axis` is out of bounds<br>
     /// ***Panics*** if not `index < self.len_of(axis)`.
     pub fn remove_index(&mut self, axis: Axis, index: usize)
-    // TODO: Check whether this needed to be DataOwned
     {
         assert!(index < self.len_of(axis), "index {} must be less than length of Axis({})",
                 index, axis.index());
@@ -3125,7 +3130,10 @@ impl<A, D: Dimension> ArrayRef<A, D>
         // then slice the axis in place to cut out the removed final element
         self.slice_axis_inplace(axis, Slice::new(0, Some(-1), 1));
     }
+}
 
+impl<A, D: Dimension> ArrayRef<A, D>
+{
     /// Iterates over pairs of consecutive elements along the axis.
     ///
     /// The first argument to the closure is an element, and the second
