Experiment with C++17 #2488
Draft
Experiment with C++17 #2488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7035c1b to
b537889
Compare
|
It appears that all the CI targets support C++17. So we should consider using these features after releasing 1.95. |
gaul
commented
Jul 12, 2024
| @@ -229,12 +230,13 @@ static unique_ptr_xmlChar get_exp_value_xml(xmlDocPtr doc, xmlXPathContextPtr ct | |||
| return exp_value; | |||
| } | |||
|
|
|||
| bool get_incomp_mpu_list(xmlDocPtr doc, incomp_mpu_list_t& list) | |||
| std::optional<incomp_mpu_list_t> get_incomp_mpu_list(xmlDocPtr doc) | |||
There was a problem hiding this comment.
I don't think C++17 has major advancements compared to C++11 but std::optional will make error checking more obvious and safer. These kinds of little enhancements must wait until after we release 1.95 in #2496.
Most of these features should work now that we dropped CentOS 7 support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these features should work now that we dropped CentOS 7 support.