Implement nb_bool for Producer which makes bool(Producer(...)) return True irrespective of the length of the queue (confluentinc#1445)

vladz-sternum · web-flow · commit 16b774770515 · 2023-01-06T11:02:53.000+05:30
diff --git a/src/confluent_kafka/src/Producer.c b/src/confluent_kafka/src/Producer.c
@@ -824,6 +824,23 @@ static PySequenceMethods Producer_seq_methods = {
 	(lenfunc)Producer__len__ /* sq_length */
 };
 
+static int Producer__bool__ (Handle *self) {
+        return 1;
+}
+
+static PyNumberMethods Producer_num_methods = {
+     0, // nb_add
+     0, // nb_subtract
+     0, // nb_multiply
+     0, // nb_remainder
+     0, // nb_divmod
+     0, // nb_power
+     0, // nb_negative
+     0, // nb_positive
+     0, // nb_absolute
+     (inquiry)Producer__bool__ // nb_bool
+};
+
 
 static int Producer_init (PyObject *selfobj, PyObject *args, PyObject *kwargs) {
         Handle *self = (Handle *)selfobj;
@@ -879,8 +896,8 @@ PyTypeObject ProducerType = {
 	0,                         /*tp_setattr*/
 	0,                         /*tp_compare*/
 	0,                         /*tp_repr*/
-	0,                         /*tp_as_number*/
-	&Producer_seq_methods,  /*tp_as_sequence*/
+	&Producer_num_methods,     /*tp_as_number*/
+	&Producer_seq_methods,     /*tp_as_sequence*/
 	0,                         /*tp_as_mapping*/
 	0,                         /*tp_hash */
 	0,                         /*tp_call*/
diff --git a/tests/test_Producer.py b/tests/test_Producer.py
@@ -271,3 +271,13 @@ def on_delivery(err, msg):
     p.purge()
     p.flush(0.002)
     assert cb_detector["on_delivery_called"]
+
+
+def test_producer_bool_value():
+    """
+    Make sure producer has a truth-y bool value
+    See https://github.com/confluentinc/confluent-kafka-python/issues/1427
+    """
+
+    p = Producer({})
+    assert bool(p)
