fix download without path arguments (python-telegram-bot#1591)

GabrielSimonetto · Bibo-Joshi · web-flow · commit bacabbe767de · 2020-02-06T11:21:21.000+01:00
* fix download without path arguments

* fix download without path arguments

* solved downloading a file without file_path or custom_path

* if no file_path, download as file_id

* Add test case

* Elaborate doc string

Co-authored-by: Bibo-Joshi &lt;hinrich.mahler@freenet.de&gt;
diff --git a/telegram/files/file.py b/telegram/files/file.py
@@ -19,6 +19,7 @@
 """This module contains an object that represents a Telegram File."""
 from base64 import b64decode
 from os.path import basename
+import os
 
 from future.backports.urllib import parse as urllib_parse
 
@@ -76,9 +77,10 @@ def de_json(cls, data, bot):
     def download(self, custom_path=None, out=None, timeout=None):
         """
         Download this file. By default, the file is saved in the current working directory with its
-        original filename as reported by Telegram. If a :attr:`custom_path` is supplied, it will be
-        saved to that path instead. If :attr:`out` is defined, the file contents will be saved to
-        that object using the ``out.write`` method.
+        original filename as reported by Telegram. If the file has no filename, it the file ID will
+        be used as filename. If a :attr:`custom_path` is supplied, it will be saved to that path
+        instead. If :attr:`out` is defined, the file contents will be saved to that object using
+        the ``out.write`` method.
 
         Note:
             :attr:`custom_path` and :attr:`out` are mutually exclusive.
@@ -116,8 +118,10 @@ def download(self, custom_path=None, out=None, timeout=None):
         else:
             if custom_path:
                 filename = custom_path
-            else:
+            elif self.file_path:
                 filename = basename(self.file_path)
+            else:
+                filename = os.path.join(os.getcwd(), self.file_id)
 
             buf = self.bot.request.retrieve(url, timeout=timeout)
             if self._credentials:
diff --git a/tests/test_file.py b/tests/test_file.py
@@ -96,6 +96,22 @@ def test(*args, **kwargs):
             os.close(file_handle)
             os.unlink(custom_path)
 
+    def test_download_no_filename(self, monkeypatch, file):
+        def test(*args, **kwargs):
+            return self.file_content
+
+        file.file_path = None
+
+        monkeypatch.setattr('telegram.utils.request.Request.retrieve', test)
+        out_file = file.download()
+
+        assert out_file[-len(file.file_id):] == file.file_id
+        try:
+            with open(out_file, 'rb') as fobj:
+                assert fobj.read() == self.file_content
+        finally:
+            os.unlink(out_file)
+
     def test_download_file_obj(self, monkeypatch, file):
         def test(*args, **kwargs):
             return self.file_content
