Avoid recursion error in profiling (#92)

xadupre · web-flow · commit 07c3683614b9 · 2024-12-20T15:57:52.000+01:00
* Avoid recursion error in profiling

* disable two tests

* disable tests
diff --git a/CHANGELOGS.rst b/CHANGELOGS.rst
@@ -4,7 +4,8 @@ Change Logs
 0.3.0
 +++++
 
-* :pr:`87`: add command line to replace contant by ConstantOfShape
+* :pr:`92`: avoids recursion errors in profiling
+* :pr:`87`: adds command line to replace contant by ConstantOfShape
 * :pr:`79`: first draft to export to GraphBuilder
 * :pr:`77`: supports ConcatOfShape and Slice with the light API
 
diff --git a/_unittests/ut_npx/test_sklearn_array_api.py b/_unittests/ut_npx/test_sklearn_array_api.py
@@ -17,6 +17,7 @@ class TestSklearnArrayAPI(ExtTestCase):
         reason="reshape ArrayAPI not followed",
     )
     @ignore_warnings(DeprecationWarning)
+    @unittest.skip("not maintained")
     def test_sklearn_array_api_linear_discriminant(self):
         X = np.array(
             [[-1, -1], [-2, -1], [-3, -2], [1, 1], [2, 1], [3, 2]], dtype=np.float64
@@ -39,6 +40,7 @@ def test_sklearn_array_api_linear_discriminant(self):
         reason="reshape ArrayAPI not followed",
     )
     @ignore_warnings(DeprecationWarning)
+    @unittest.skip("not maintained")
     def test_sklearn_array_api_linear_discriminant_float32(self):
         X = np.array(
             [[-1, -1], [-2, -1], [-3, -2], [1, 1], [2, 1], [3, 2]], dtype=np.float32
diff --git a/_unittests/ut_ort/test_sklearn_array_api_ort.py b/_unittests/ut_ort/test_sklearn_array_api_ort.py
@@ -17,6 +17,7 @@ class TestSklearnArrayAPIOrt(ExtTestCase):
         reason="reshape ArrayAPI not followed",
     )
     @skipif_ci_windows("Unstable on Windows.")
+    @unittest.skip("discontinued")
     def test_sklearn_array_api_linear_discriminant_ort(self):
         X = np.array(
             [[-1, -1], [-2, -1], [-3, -2], [1, 1], [2, 1], [3, 2]], dtype=np.float64
@@ -40,6 +41,7 @@ def test_sklearn_array_api_linear_discriminant_ort(self):
         reason="reshape ArrayAPI not followed",
     )
     @skipif_ci_windows("Unstable on Windows.")
+    @unittest.skip("discontinued")
     def test_sklearn_array_api_linear_discriminant_ort_float32(self):
         X = np.array(
             [[-1, -1], [-2, -1], [-3, -2], [1, 1], [2, 1], [3, 2]], dtype=np.float32
diff --git a/onnx_array_api/profiling.py b/onnx_array_api/profiling.py
@@ -73,8 +73,8 @@ def _get_root(node, stor=None):
                 stor.append(node)
             if not node.called_by:
                 return node
-            if len(node.called_by) == 1:
-                return _get_root(node.called_by[0], stor=stor)
+            if len(node.called_by) == 0:
+                return None
             res = None
             for ct in node.called_by:
                 k = id(node), id(ct)
