fix(socks): bracket IPv6 addresses when formatting destination host (#2753)

0x676e67 · web-flow · commit a9ab0fae3fa9 · 2025-07-01T08:12:27.000-04:00
diff --git a/src/connect.rs b/src/connect.rs
@@ -1294,7 +1294,13 @@ mod socks {
                 .next();
             if let Some(new_target) = maybe_new_target {
                 log::trace!("socks local dns resolved {new_target:?}");
-                host = new_target.ip().to_string();
+                // If the resolved IP is IPv6, wrap it in brackets for URI formatting
+                let ip = new_target.ip();
+                if ip.is_ipv6() {
+                    host = format!("[{}]", ip);
+                } else {
+                    host = ip.to_string();
+                }
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -1294,7 +1294,13 @@ mod socks {`
`1294`	`1294`	`.next();`
`1295`	`1295`	`if let Some(new_target) = maybe_new_target {`
`1296`	`1296`	`log::trace!("socks local dns resolved {new_target:?}");`
`1297`		`- host = new_target.ip().to_string();`
	`1297`	`+ // If the resolved IP is IPv6, wrap it in brackets for URI formatting`
	`1298`	`+ let ip = new_target.ip();`
	`1299`	`+ if ip.is_ipv6() {`
	`1300`	`+ host = format!("[{}]", ip);`
	`1301`	`+ } else {`
	`1302`	`+ host = ip.to_string();`
	`1303`	`+ }`
`1298`	`1304`	`}`
`1299`	`1305`	`}`
`1300`	`1306`