Added CEL to list of valid ExpressionLangs (#188)

venera-program · web-flow · commit f50885cae862 · 2023-09-19T11:06:16.000-03:00
Signed-off-by: Venera &lt;31911811+venera-program@users.noreply.github.com&gt;
diff --git a/model/workflow.go b/model/workflow.go
@@ -75,6 +75,7 @@ func (i ExpressionLangType) KindValues() []string {
 	return []string{
 		string(JqExpressionLang),
 		string(JsonPathExpressionLang),
+		string(CELExpressionLang),
 	}
 }
 
@@ -88,6 +89,9 @@ const (
 
 	// JsonPathExpressionLang ...
 	JsonPathExpressionLang ExpressionLangType = "jsonpath"
+
+	// CELExpressionLang
+	CELExpressionLang ExpressionLangType = "cel"
 )
 
 // BaseWorkflow describes the partial Workflow definition that does not rely on generic interfaces
@@ -132,7 +136,7 @@ type BaseWorkflow struct {
 	// +optional
 	Constants *Constants `json:"constants,omitempty"`
 	// Identifies the expression language used for workflow expressions. Default is 'jq'.
-	// +kubebuilder:validation:Enum=jq;jsonpath
+	// +kubebuilder:validation:Enum=jq;jsonpath;cel
 	// +kubebuilder:default=jq
 	// +optional
 	ExpressionLang ExpressionLangType `json:"expressionLang,omitempty" validate:"required,oneofkind"`
diff --git a/model/workflow_validator_test.go b/model/workflow_validator_test.go
@@ -162,7 +162,7 @@ workflow.key required when "workflow.id" is not defined`,
 				model.BaseWorkflow.ExpressionLang = JqExpressionLang + "invalid"
 				return *model
 			},
-			Err: `workflow.expressionLang need by one of [jq jsonpath]`,
+			Err: `workflow.expressionLang need by one of [jq jsonpath cel]`,
 		},
 	}
 

Original file line number	Diff line number	Diff line change
@@ -162,7 +162,7 @@ workflow.key required when "workflow.id" is not defined`,
`162`	`162`	`model.BaseWorkflow.ExpressionLang = JqExpressionLang + "invalid"`
`163`	`163`	`return *model`
`164`	`164`	`},`
`165`		- Err: `workflow.expressionLang need by one of [jq jsonpath]`,
	`165`	+ Err: `workflow.expressionLang need by one of [jq jsonpath cel]`,
`166`	`166`	`},`
`167`	`167`	`}`
`168`	`168`