From ceea13fc5ad7b9ac72783474379b49fc8e805a54 Mon Sep 17 00:00:00 2001 From: Dmitrii Tikhomirov Date: Tue, 29 Apr 2025 11:19:36 -0700 Subject: [PATCH 1/6] Set EventRef.ResultEventRef to optional (#239) * Set EventRef.ResultEventRef to optional Signed-off-by: Dmitrii Tikhomirov * removed validate declaration and updated tests Signed-off-by: Dmitrii Tikhomirov --------- Signed-off-by: Dmitrii Tikhomirov --- model/event.go | 4 ++-- model/event_validator_test.go | 4 +--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/model/event.go b/model/event.go index bad1ce4..ddc5ab2 100644 --- a/model/event.go +++ b/model/event.go @@ -96,8 +96,8 @@ type EventRef struct { // +kubebuilder:validation:Required TriggerEventRef string `json:"triggerEventRef" validate:"required"` // Reference to the unique name of a 'consumed' event definition - // +kubebuilder:validation:Required - ResultEventRef string `json:"resultEventRef" validate:"required"` + // +optional + ResultEventRef string `json:"resultEventRef"` // Maximum amount of time (ISO 8601 format) to wait for the result event. If not defined it be set to the // actionExecutionTimeout // +optional diff --git a/model/event_validator_test.go b/model/event_validator_test.go index 80340b0..89566e8 100644 --- a/model/event_validator_test.go +++ b/model/event_validator_test.go @@ -175,11 +175,9 @@ func TestEventRefStructLevelValidation(t *testing.T) { Model: func() Workflow { model := baseWorkflow.DeepCopy() model.States[0].OperationState.Actions[0].EventRef.TriggerEventRef = "" - model.States[0].OperationState.Actions[0].EventRef.ResultEventRef = "" return *model }, - Err: `workflow.states[0].actions[0].eventRef.triggerEventRef is required -workflow.states[0].actions[0].eventRef.resultEventRef is required`, + Err: `workflow.states[0].actions[0].eventRef.triggerEventRef is required`, }, { Desp: "exists", From a4df4908d96c72f919ac9cd6d227ee1e9927c6c6 Mon Sep 17 00:00:00 2001 From: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> Date: Fri, 9 May 2025 09:42:22 -0400 Subject: [PATCH 2/6] Run checks on 2.* branches --- .github/workflows/Go-SDK-PR-Check.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/Go-SDK-PR-Check.yaml b/.github/workflows/Go-SDK-PR-Check.yaml index 7b8a8a3..f8878ae 100644 --- a/.github/workflows/Go-SDK-PR-Check.yaml +++ b/.github/workflows/Go-SDK-PR-Check.yaml @@ -22,6 +22,7 @@ on: - "Makefile" branches: - main + - 2.* permissions: contents: read From 1b22f6d250e018149205e4af29f16154b749eb49 Mon Sep 17 00:00:00 2001 From: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> Date: Fri, 9 May 2025 09:45:12 -0400 Subject: [PATCH 3/6] Prepare release 2.6.0 --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index e4d87c6..8d38969 100644 --- a/README.md +++ b/README.md @@ -33,7 +33,8 @@ Current status of features implemented in the SDK is listed in the table below: | [v1.0.0](https://github.com/serverlessworkflow/sdk-go/releases/tag/v1.0.0) | [v0.5](https://github.com/serverlessworkflow/specification/tree/0.5.x) | | [v2.0.1](https://github.com/serverlessworkflow/sdk-go/releases/tag/v2.0.1) | [v0.6](https://github.com/serverlessworkflow/specification/tree/0.6.x) | | [v2.1.2](https://github.com/serverlessworkflow/sdk-go/releases/tag/v2.1.2) | [v0.7](https://github.com/serverlessworkflow/specification/tree/0.7.x) | -| [v2.4.1](https://github.com/serverlessworkflow/sdk-go/releases/tag/v2.4.1) | [v0.8](https://github.com/serverlessworkflow/specification/tree/0.8.x) | +| [v2.5.0](https://github.com/serverlessworkflow/sdk-go/releases/tag/v2.5.0) | [v0.8](https://github.com/serverlessworkflow/specification/tree/0.8.x) | +| [v2.6.0](https://github.com/serverlessworkflow/sdk-go/releases/tag/v2.6.0) | [v0.0](https://github.com/serverlessworkflow/specification/tree/0.8.x) | ## How to use From 6166abbaba8706c461355be6594fe300c0ee91a0 Mon Sep 17 00:00:00 2001 From: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> Date: Fri, 9 May 2025 09:45:34 -0400 Subject: [PATCH 4/6] Fix version 0.9 number --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 8d38969..f09ff4e 100644 --- a/README.md +++ b/README.md @@ -34,7 +34,7 @@ Current status of features implemented in the SDK is listed in the table below: | [v2.0.1](https://github.com/serverlessworkflow/sdk-go/releases/tag/v2.0.1) | [v0.6](https://github.com/serverlessworkflow/specification/tree/0.6.x) | | [v2.1.2](https://github.com/serverlessworkflow/sdk-go/releases/tag/v2.1.2) | [v0.7](https://github.com/serverlessworkflow/specification/tree/0.7.x) | | [v2.5.0](https://github.com/serverlessworkflow/sdk-go/releases/tag/v2.5.0) | [v0.8](https://github.com/serverlessworkflow/specification/tree/0.8.x) | -| [v2.6.0](https://github.com/serverlessworkflow/sdk-go/releases/tag/v2.6.0) | [v0.0](https://github.com/serverlessworkflow/specification/tree/0.8.x) | +| [v2.6.0](https://github.com/serverlessworkflow/sdk-go/releases/tag/v2.6.0) | [v0.9](https://github.com/serverlessworkflow/specification/tree/0.9.x) | ## How to use From 92ef1bf02a91ef26d97751d030b7ba1e3ef3791d Mon Sep 17 00:00:00 2001 From: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> Date: Fri, 9 May 2025 10:01:46 -0400 Subject: [PATCH 5/6] Delete .github/workflows/pull_request_labeler.yml --- .github/workflows/pull_request_labeler.yml | 26 ---------------------- 1 file changed, 26 deletions(-) delete mode 100644 .github/workflows/pull_request_labeler.yml diff --git a/.github/workflows/pull_request_labeler.yml b/.github/workflows/pull_request_labeler.yml deleted file mode 100644 index f270294..0000000 --- a/.github/workflows/pull_request_labeler.yml +++ /dev/null @@ -1,26 +0,0 @@ -# Copyright 2022 The Serverless Workflow Specification Authors -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -name: "Pull Request Labeler" -on: - - pull_request_target - -jobs: - labeler: - permissions: - contents: read - pull-requests: write - runs-on: ubuntu-latest - steps: - - uses: actions/labeler@v5 \ No newline at end of file From 507d8ab886533bbfe2665e4a966e4974375451e0 Mon Sep 17 00:00:00 2001 From: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com> Date: Fri, 9 May 2025 10:01:59 -0400 Subject: [PATCH 6/6] Delete .github/labeler.yml --- .github/labeler.yml | 20 -------------------- 1 file changed, 20 deletions(-) delete mode 100644 .github/labeler.yml diff --git a/.github/labeler.yml b/.github/labeler.yml deleted file mode 100644 index 49abd17..0000000 --- a/.github/labeler.yml +++ /dev/null @@ -1,20 +0,0 @@ -# Copyright 2022 The Serverless Workflow Specification Authors -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -"documentation :notebook:": - - changed-files: - - any-glob-to-any-file: ['contrib/*', '**/*.md'] -kubernetes: - - changed-files: - - any-glob-to-any-file: ['kubernetes/*', 'hack/builder-gen.sh', 'hack/deepcopy-gen.sh', 'Makefile'] pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy