fix(SDK): Fixed the FunctionDefinitionValidator, which was attempting to resolve an authentication reference against an event definition (instead of resolving it against an authentication definition)

cdavernas · cdavernas · commit ab7f317843de · 2022-08-11T12:21:20.000+02:00
diff --git a/src/ServerlessWorkflow.Sdk/ServerlessWorkflow.Sdk.csproj b/src/ServerlessWorkflow.Sdk/ServerlessWorkflow.Sdk.csproj
@@ -4,9 +4,9 @@
     <TargetFramework>net6.0</TargetFramework>
 	<Nullable>enable</Nullable>
     <NeutralLanguage>en</NeutralLanguage>
-    <AssemblyVersion>0.8.1.7</AssemblyVersion>
-    <FileVersion>0.8.1.7</FileVersion>
-    <Version>0.8.1.7</Version>
+    <AssemblyVersion>0.8.1.8</AssemblyVersion>
+    <FileVersion>0.8.1.8</FileVersion>
+    <Version>0.8.1.8</Version>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
     <PackageLicenseFile>LICENSE</PackageLicenseFile>
diff --git a/src/ServerlessWorkflow.Sdk/Services/Validation/FunctionDefinitionValidator.cs b/src/ServerlessWorkflow.Sdk/Services/Validation/FunctionDefinitionValidator.cs
@@ -59,7 +59,7 @@ public FunctionDefinitionValidator(WorkflowDefinition workflow)
         /// <returns>A boolean indicating whether or not the specified <see cref="AuthenticationDefinition"/> exists</returns>
         protected virtual bool ReferenceExistingAuthentication(string authenticationName)
         {
-            return this.Workflow.TryGetEvent(authenticationName, out _);
+            return this.Workflow.TryGetAuthentication(authenticationName, out _);
         }
 
     }

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public FunctionDefinitionValidator(WorkflowDefinition workflow)`
`59`	`59`	`/// <returns>A boolean indicating whether or not the specified <see cref="AuthenticationDefinition"/> exists</returns>`
`60`	`60`	`protected virtual bool ReferenceExistingAuthentication(string authenticationName)`
`61`	`61`	`{`
`62`		`- return this.Workflow.TryGetEvent(authenticationName, out _);`
	`62`	`+ return this.Workflow.TryGetAuthentication(authenticationName, out _);`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`}`