fix(SDK): Made all authentication schemes properties nullable, enabling proper ASP.NET validation when using secret-based authentication

cdavernas · cdavernas · commit dc0f7b64cb6f · 2024-09-06T17:33:05.000+02:00
Signed-off-by: Charles d'Avernas &lt;charles.davernas@neuroglia.io&gt;
diff --git a/src/ServerlessWorkflow.Sdk/Models/Authentication/BasicAuthenticationSchemeDefinition.cs b/src/ServerlessWorkflow.Sdk/Models/Authentication/BasicAuthenticationSchemeDefinition.cs
@@ -29,12 +29,12 @@ public record BasicAuthenticationSchemeDefinition
     /// Gets/sets the username used for authentication
     /// </summary>
     [DataMember(Name = "username", Order = 1), JsonPropertyName("username"), JsonPropertyOrder(1), YamlMember(Alias = "username", Order = 1)]
-    public virtual string Username { get; set; } = null!;
+    public virtual string? Username { get; set; }
 
     /// <summary>
     /// Gets/sets the password used for authentication
     /// </summary>
     [DataMember(Name = "password", Order = 2), JsonPropertyName("password"), JsonPropertyOrder(2), YamlMember(Alias = "password", Order = 2)]
-    public virtual string Password { get; set; } = null!;
+    public virtual string? Password { get; set; }
 
 }
diff --git a/src/ServerlessWorkflow.Sdk/Models/Authentication/BearerAuthenticationSchemeDefinition.cs b/src/ServerlessWorkflow.Sdk/Models/Authentication/BearerAuthenticationSchemeDefinition.cs
@@ -29,6 +29,6 @@ public record BearerAuthenticationSchemeDefinition
     /// Gets/sets the bearer token used for authentication
     /// </summary>
     [DataMember(Name = "token", Order = 1), JsonPropertyName("token"), JsonPropertyOrder(1), YamlMember(Alias = "token", Order = 1)]
-    public virtual string Token { get; set; } = null!;
+    public virtual string? Token { get; set; }
 
 }
diff --git a/src/ServerlessWorkflow.Sdk/Models/Authentication/DigestAuthenticationSchemeDefinition.cs b/src/ServerlessWorkflow.Sdk/Models/Authentication/DigestAuthenticationSchemeDefinition.cs
@@ -29,12 +29,12 @@ public record DigestAuthenticationSchemeDefinition
     /// Gets/sets the username used for authentication
     /// </summary>
     [DataMember(Name = "username", Order = 1), JsonPropertyName("username"), JsonPropertyOrder(1), YamlMember(Alias = "username", Order = 1)]
-    public virtual string Username { get; set; } = null!;
+    public virtual string? Username { get; set; }
 
     /// <summary>
     /// Gets/sets the password used for authentication
     /// </summary>
     [DataMember(Name = "password", Order = 2), JsonPropertyName("password"), JsonPropertyOrder(2), YamlMember(Alias = "password", Order = 2)]
-    public virtual string Password { get; set; } = null!;
+    public virtual string? Password { get; set; }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,6 @@ public record BearerAuthenticationSchemeDefinition`
`29`	`29`	`/// Gets/sets the bearer token used for authentication`
`30`	`30`	`/// </summary>`
`31`	`31`	`[DataMember(Name = "token", Order = 1), JsonPropertyName("token"), JsonPropertyOrder(1), YamlMember(Alias = "token", Order = 1)]`
`32`		`- public virtual string Token { get; set; } = null!;`
	`32`	`+ public virtual string? Token { get; set; }`
`33`	`33`
`34`	`34`	`}`