-
Notifications
You must be signed in to change notification settings - Fork 41
Description
We already have message types defined that describe the inputs to the verification process (Bundle
, TrustedRoot
, ArtifactVerificationOptions
) so it seems reasonable to also define a standardized verification response. This will give clients a standard way to convey more specific verification errors (and make it easier to compare the verification results across the different client implementations).
I'm not married to this particular design, but offering it as a starting point for refinement:
enum VerificationStep {
// Verify the signature w/ the leaf certificate in the chain
SIGNATURE = 1;
// Verify the certificate chain back to the root of the identity service
CERTIFICATE_CHAIN = 2;
// Verify the SET of the transparency log entry
TRANSPARENCY_LOG = 3;
// Verify the signed timestamp is valid and trusted
TIMESTAMP_AUTHORITY = 4;
// Verify the signature timestamp (either from tlog SET or timestamp authority) is within certificate's validity period
SIGNATURE_TIMESTAMP = 5;
}
message VerificationResult {
bool success = 1;
optional string message = 2;
optional VerificationStep failed_step = 3;
}
If we go with this idea of having some sort of enum to identity the specific verification step which failed we could go even more granular (e.g. CERTIFICATE_CHAIN_SCT
, TRANSPARENCY_LOG_INCLUSION_PROOF
, etc) . . . not clear to me what the most useful level of detail is gonna be.
Another thing which occurs to me is that it might be helpful for the VerificationResult
to surface the Fulcio certificate extensions (in the case where the verification is successful). The extensions are probably the next things any client is gonna read after verifying the bundle and this could save them the trouble of fishing them out of the certificate.