Add a setting to control truncation limit (max msg length)

jsmnbom · jsmnbom · commit 0dd1b9bdee1d · 2018-11-02T12:07:06.000+01:00
diff --git a/bot/const.py b/bot/const.py
@@ -14,3 +14,4 @@
 GITHUB_OAUTH_CLIENT_SECRET = os.getenv('GITHUB_OAUTH_CLIENT_SECRET')
 GITHUB_OAUTH_REDIRECT_URI = SERVER_URL_BASE + '/github/auth'
 DEBUG = os.getenv('DEBUG', False)
+DEFAULT_TRUNCATION_LIMIT = 4096
diff --git a/bot/github.py b/bot/github.py
@@ -4,6 +4,7 @@
 from telegram import ParseMode
 from telegram.ext import CallbackContext, Dispatcher
 
+from bot.const import DEFAULT_TRUNCATION_LIMIT
 from bot.githubapi import github_api
 from bot.githubupdates import GithubAuthUpdate, GithubUpdate
 from bot.menu import edit_menu_by_id
@@ -55,13 +56,19 @@ def _iter_repos(self, repository):
             if 'repos' in chat_data:
                 for repo in chat_data['repos'].values():
                     if repo.id == repo_id:
-                        yield chat_id, repo
+                        yield chat_id, chat_data, repo
 
     def _send(self, repo, text, check_repo: Callable[[Repo], bool], suffix=REPLY_MESSAGE):
-        text = truncate(text, TRUNCATED_MESSAGE, suffix)
+        truncated_text = {}
 
-        for chat_id, repo in self._iter_repos(repo):
+        for chat_id, chat_data, repo in self._iter_repos(repo):
             if check_repo(repo):
+                truncation_limit = chat_data.get('truncation_limit', DEFAULT_TRUNCATION_LIMIT)
+                try:
+                    text = truncated_text[truncation_limit]
+                except KeyError:
+                    text = truncate(text, TRUNCATED_MESSAGE, suffix, max_length=truncation_limit)
+
                 self.dispatcher.bot.send_message(chat_id=chat_id, text=text,
                                                  parse_mode=ParseMode.HTML, disable_web_page_preview=True)
 
diff --git a/bot/settings.py b/bot/settings.py
@@ -4,6 +4,7 @@
 from telegram import Chat, InlineQueryResultArticle, InputTextMessageContent, ParseMode
 from telegram.ext import Dispatcher, InlineQueryHandler, CommandHandler
 
+from bot.const import DEFAULT_TRUNCATION_LIMIT
 from bot.github import github_api
 from bot.menu import Button, Menu, BackButton, reply_menu, MenuHandler, ToggleButton, SetButton
 from bot.repo import Repo
@@ -56,8 +57,9 @@ def settings_buttons(update, context):
         else:
             buttons.append(Button('🔑 Login', menu='login'))
     else:
-        buttons.append(Button('👤 User settings', url=f'https://telegram.me/{context.bot.username}?start=settings'))
+        buttons.append(Button('👤 Go to User settings', url=f'https://telegram.me/{context.bot.username}?start=settings'))
 
+    buttons.append(Button('👥 Chat settings', menu='chat'))
     buttons.append(Button('🗃️ Repositories', menu='repos'))
 
     return [[button] for button in buttons]
@@ -172,6 +174,39 @@ def repo_set_data(update, context):
 )
 
 
+def chat_text(update, context):
+    if update.effective_chat.title:
+        chat = update.effective_chat.title
+    elif update.effective_chat.first_name:
+        chat = f'this chat with {update.effective_chat.first_name}'
+    else:
+        chat = 'this chat'
+    return f'⚙ Settings for {context.bot.name} for {chat}\n\n'
+
+
+def chat_buttons(update, context):
+    truncation_limit = context.chat_data.get('truncation_limit', DEFAULT_TRUNCATION_LIMIT)
+    truncation_limits = [256, 512, 1024, 2048, 4096]
+    truncation_limit_states = [(limit, f'Max notification message length: {limit}') for limit in truncation_limits]
+
+    return [
+        [ToggleButton('truncation_limit', truncation_limit, states=truncation_limit_states)],
+        [BackButton(BACK)]
+    ]
+
+
+def chat_set_data(update, context):
+    context.chat_data[context.key] = context.value
+
+
+chat_settings_menu = Menu(
+    name='chat',
+    text=chat_text,
+    buttons=chat_buttons,
+    set_data=chat_set_data
+)
+
+
 def settings_command(update, context):
     if context.args:
         context.menu_stack = context.args
@@ -265,7 +300,8 @@ def add_handlers(dp: Dispatcher):
     dp.add_handler(MenuHandler(settings_menu, [
         repos_menu,
         repo_menu,
-        login_menu
+        login_menu,
+        chat_settings_menu
     ]))
 
     dp.add_handler(InlineQueryHandler(inline_add_repo, pattern=InlineQueries.add_repo + r'(.*)'))
