[FMX Render] Fix AV using Skia Metal and Vulkan as render

viniciusfbb · paulocesarbot · viniciusfbb · commit 69b6725eddcd · 2025-07-21T15:27:29.000-03:00
#413 Co-Authored-By: Paulo César Botelho Barbosa <16469061+paulocesarbot@users.noreply.github.com>
diff --git a/Source/FMX/FMX.Skia.Canvas.pas b/Source/FMX/FMX.Skia.Canvas.pas
@@ -162,17 +162,21 @@   TSkCanvasCustomClass = class of TSkCanvasCustom;
 
   TSkBitmapHandle = class
   private
-    FPixels: Pointer;
+    function GetPixels: Pointer; overload;
+    function GetPixels(AInitializeToZero: Boolean): Pointer; overload; inline;
   strict private
     FHeight: Integer;
     FPixelFormat: TPixelFormat;
+    FPixels: Pointer;
+    FPixelsBytes: NativeUInt;
     FWidth: Integer;
   public
     constructor Create(const AWidth, AHeight: Integer; const APixelFormat: TPixelFormat);
     destructor Destroy; override;
     property Height: Integer read FHeight;
     property PixelFormat: TPixelFormat read FPixelFormat;
-    property Pixels: Pointer read FPixels;
+    property Pixels: Pointer read GetPixels;
+    property PixelsBytes: NativeUInt read FPixelsBytes;
     property Width: Integer read FWidth;
   end;
 
@@ -2460,6 +2464,8 @@ constructor TSkBitmapHandle.Create(const AWidth, AHeight: Integer;
   FWidth       := AWidth;
   FHeight      := AHeight;
   FPixelFormat := APixelFormat;
+  if (AWidth > 0) and (AHeight > 0) and (PixelFormatBytes[APixelFormat] > 0) then
+    FPixelsBytes := NativeUInt(AWidth) * NativeUInt(AHeight) * NativeUInt(PixelFormatBytes[APixelFormat]);
 end;
 
 destructor TSkBitmapHandle.Destroy;
@@ -2468,6 +2474,23 @@ destructor TSkBitmapHandle.Destroy;
   inherited;
 end;
 
+function TSkBitmapHandle.GetPixels(AInitializeToZero: Boolean): Pointer;
+begin
+  if (FPixels = nil) and (FPixelsBytes > 0) then
+  begin
+    if AInitializeToZero then
+      FPixels := AllocMem(FPixelsBytes)
+    else
+      GetMem(FPixels, FPixelsBytes);
+  end;
+  Result := FPixels;
+end;
+
+function TSkBitmapHandle.GetPixels: Pointer;
+begin
+  Result := GetPixels(True);
+end;
+
 { TSkCanvasBase }
 
 function TSkCanvasBase.BeginCanvas(const AContextHandle: THandle): ISkCanvas;
@@ -2484,8 +2507,6 @@ function TSkCanvasBase.BeginCanvas(const AContextHandle: THandle): ISkCanvas;
   else if Bitmap <> nil then
   begin
     LBitmap := TSkBitmapHandle(Bitmap.Handle);
-    if LBitmap.Pixels = nil then
-      LBitmap.FPixels := AllocMem(NativeInt(LBitmap.Width) * LBitmap.Height * PixelFormatBytes[LBitmap.PixelFormat]);
     FBitmapSurface := TSkSurface.MakeRasterDirect(TSkImageInfo.Create(LBitmap.Width, LBitmap.Height, SkFmxColorType[LBitmap.PixelFormat]), LBitmap.Pixels, LBitmap.Width * PixelFormatBytes[LBitmap.PixelFormat]);
     Result         := FBitmapSurface.Canvas;
   end
@@ -2550,14 +2571,7 @@ class function TSkCanvasBase.DoMapBitmap(const ABitmapHandle: THandle;
   LBitmap: TSkBitmapHandle;
 begin
   LBitmap := TSkBitmapHandle(ABitmapHandle);
-  if LBitmap.Pixels = nil then
-  begin
-    if AAccess = TMapAccess.Write then
-      GetMem(LBitmap.FPixels, LBitmap.Width * LBitmap.Height * PixelFormatBytes[LBitmap.PixelFormat])
-    else
-      LBitmap.FPixels := AllocMem(LBitmap.Width * LBitmap.Height * PixelFormatBytes[LBitmap.PixelFormat]);
-  end;
-  ABitmapData.Data  := LBitmap.Pixels;
+  ABitmapData.Data  := LBitmap.GetPixels(AAccess <> TMapAccess.Write);
   ABitmapData.Pitch := LBitmap.Width * PixelFormatBytes[LBitmap.PixelFormat];
   Result := True;
 end;
@@ -2652,13 +2666,15 @@ function TGrSharedContext.GetGrDirectContext: TGrDirectContext;
   Result := TGrDirectContext(FGrDirectContext);
 end;
 
-procedure TGrSharedContext.InitializeTextureCache(
-  const ABitmap: TGrBitmapHandle);
+procedure TGrSharedContext.InitializeTextureCache(const ABitmap: TGrBitmapHandle);
 var
   LImage: ISkImage;
 begin
-  LImage := TSkImage.MakeFromRaster(TSkImageInfo.Create(ABitmap.Width, ABitmap.Height, SkFmxColorType[ABitmap.PixelFormat]), ABitmap.Pixels, ABitmap.Width * PixelFormatBytes[ABitmap.PixelFormat]);
-  ABitmap.Cache := LImage.MakeTextureImage(ABitmap.SharedContext.GrDirectContext);
+  LImage := TSkImage.MakeFromRaster(
+    TSkImageInfo.Create(ABitmap.Width, ABitmap.Height, SkFmxColorType[ABitmap.PixelFormat]),
+    ABitmap.Pixels, ABitmap.Width * PixelFormatBytes[ABitmap.PixelFormat]);
+  if LImage <> nil then
+    ABitmap.Cache := LImage.MakeTextureImage(ABitmap.SharedContext.GrDirectContext);
 end;
 
 procedure TGrSharedContext.RefreshContext;
