redact passwords in the right place

rtomayko · rtomayko · commit 448ba260035a · 2010-01-26T22:19:22.000-08:00
diff --git a/github-services.rb b/github-services.rb
@@ -54,9 +54,11 @@ def service(name)
           yield data, payload
         end
       rescue => boom
+        hook_data = params[:data].dup
+        %w[password token].each { |key| hook_data[key] &&= '<redacted>' }
         report_exception boom,
           :hook_name    => name,
-          :hook_data    => params[:data],
+          :hook_data    => hook_data,
           :hook_payload => params[:payload]
         raise
       end
@@ -89,7 +91,6 @@ def report_exception(exception, other)
     }
 
     # optional
-    %w[password token].each { |key| other[key] &&= '<redacted>' }
     other.each { |key, value| data[key.to_s] = value.to_s }
 
     Net::HTTP.new('aux1', 9292).
