fix: catch errors when destroying invalid upgrades

darrachequesne · darrachequesne · commit 83c4071af871 · 2022-11-20T02:23:53.000+01:00
Before this change, receiving an HTTP2 upgrade would make the server crash: > Error: read ECONNRESET > at TCP.onStreamRead (node:internal/stream_base_commons:217:20) { > errno: -104, > code: 'ECONNRESET', > syscall: 'read' > } This can be reproduced with Node.js v14.15.3, v16.18.1 and v18.12.1. Backported from 425e833
diff --git a/lib/server.js b/lib/server.js
@@ -487,6 +487,9 @@ Server.prototype.attach = function (server, options) {
         // then the socket needs to die!
         setTimeout(function () {
           if (socket.writable && socket.bytesWritten <= 0) {
+            socket.on('error', e => {
+              debug('error while destroying upgrade: %s', e.message);
+            });
             return socket.end();
           }
         }, destroyUpgradeTimeout);
