Reduced variable usage in .begin

nseidle · nseidle · commit a7038a048f99 · 2013-01-01T11:52:40.000-07:00
Removed two unneeded for loops. Also re-arranged pin setup so that we
set the pin's state before we set the pinMode.
diff --git a/SevSeg/SevSeg.cpp b/SevSeg/SevSeg.cpp
@@ -124,40 +124,33 @@ void SevSeg::Begin(boolean mode_in, byte numOfDigits,
   SegmentPins[6] = segmentG;
   SegmentPins[7] = segmentDP;
 
-  //Set Pin Modes as outputs
-  for (byte digit = 0 ; digit < numberOfDigits ; digit++) 
-  {
-    pinMode(DigitPins[digit], OUTPUT);
-  }
-  for (byte seg = 0 ; seg < 8 ; seg++) 
-  {
-    pinMode(SegmentPins[seg], OUTPUT);
-  }
-  //Turn Everything Off
+  //Turn everything Off before setting pin as output
   //Set all digit pins off. Low for common anode, high for common cathode
   for (byte digit = 0 ; digit < numberOfDigits ; digit++) 
   {
     digitalWrite(DigitPins[digit], DigitOff);
+    pinMode(DigitPins[digit], OUTPUT);
   }
   //Set all segment pins off. High for common anode, low for common cathode
   for (byte seg = 0 ; seg < 8 ; seg++) 
   {
     digitalWrite(SegmentPins[seg], SegOff);
+    pinMode(SegmentPins[seg], OUTPUT);
   }
- 
+
   if (digitColon != 255)
   {
-	pinMode(digitColon, OUTPUT);
 	digitalWrite(digitColon, DigitOff);
-	pinMode(segmentColon, OUTPUT);
+	pinMode(digitColon, OUTPUT);
 	digitalWrite(segmentColon, SegOff);
+	pinMode(segmentColon, OUTPUT);
   }
   if (digitApostrophe != 255)
   {
-	pinMode(digitApostrophe, OUTPUT);
 	digitalWrite(digitApostrophe, DigitOff);
-	pinMode(segmentApostrophe, OUTPUT);
+	pinMode(digitApostrophe, OUTPUT);
 	digitalWrite(segmentApostrophe, SegOff);
+	pinMode(segmentApostrophe, OUTPUT);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -124,40 +124,33 @@ void SevSeg::Begin(boolean mode_in, byte numOfDigits,`
`124`	`124`	`SegmentPins[6] = segmentG;`
`125`	`125`	`SegmentPins[7] = segmentDP;`
`126`	`126`
`127`		`- //Set Pin Modes as outputs`
`128`		`- for (byte digit = 0 ; digit < numberOfDigits ; digit++)`
`129`		`- {`
`130`		`- pinMode(DigitPins[digit], OUTPUT);`
`131`		`- }`
`132`		`- for (byte seg = 0 ; seg < 8 ; seg++)`
`133`		`- {`
`134`		`- pinMode(SegmentPins[seg], OUTPUT);`
`135`		`- }`
`136`		`- //Turn Everything Off`
	`127`	`+ //Turn everything Off before setting pin as output`
`137`	`128`	`//Set all digit pins off. Low for common anode, high for common cathode`
`138`	`129`	`for (byte digit = 0 ; digit < numberOfDigits ; digit++)`
`139`	`130`	`{`
`140`	`131`	`digitalWrite(DigitPins[digit], DigitOff);`
	`132`	`+ pinMode(DigitPins[digit], OUTPUT);`
`141`	`133`	`}`
`142`	`134`	`//Set all segment pins off. High for common anode, low for common cathode`
`143`	`135`	`for (byte seg = 0 ; seg < 8 ; seg++)`
`144`	`136`	`{`
`145`	`137`	`digitalWrite(SegmentPins[seg], SegOff);`
	`138`	`+ pinMode(SegmentPins[seg], OUTPUT);`
`146`	`139`	`}`
`147`		`-`
	`140`	`+`
`148`	`141`	`if (digitColon != 255)`
`149`	`142`	`{`
`150`		`- pinMode(digitColon, OUTPUT);`
`151`	`143`	`digitalWrite(digitColon, DigitOff);`
`152`		`- pinMode(segmentColon, OUTPUT);`
	`144`	`+ pinMode(digitColon, OUTPUT);`
`153`	`145`	`digitalWrite(segmentColon, SegOff);`
	`146`	`+ pinMode(segmentColon, OUTPUT);`
`154`	`147`	`}`
`155`	`148`	`if (digitApostrophe != 255)`
`156`	`149`	`{`
`157`		`- pinMode(digitApostrophe, OUTPUT);`
`158`	`150`	`digitalWrite(digitApostrophe, DigitOff);`
`159`		`- pinMode(segmentApostrophe, OUTPUT);`
	`151`	`+ pinMode(digitApostrophe, OUTPUT);`
`160`	`152`	`digitalWrite(segmentApostrophe, SegOff);`
	`153`	`+ pinMode(segmentApostrophe, OUTPUT);`
`161`	`154`	`}`
`162`	`155`	`}`
`163`	`156`