Add @nullable to StepExecution::getEndTime

acktsap · fmbenhassine · commit b919921dbb48 · 2022-02-18T15:02:21.000+01:00
Issue #4034
diff --git a/spring-batch-core/src/main/java/org/springframework/batch/core/StepExecution.java b/spring-batch-core/src/main/java/org/springframework/batch/core/StepExecution.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2006-2013 the original author or authors.
+ * Copyright 2006-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -24,6 +24,7 @@
 import java.util.concurrent.CopyOnWriteArrayList;
 
 import org.springframework.batch.item.ExecutionContext;
+import org.springframework.lang.Nullable;
 import org.springframework.util.Assert;
 
 /**
@@ -33,6 +34,7 @@
  *
  * @author Lucas Ward
  * @author Dave Syer
+ * @author Taeik Lim
  *
  */
 @SuppressWarnings("serial")
@@ -154,10 +156,11 @@ public void setCommitCount(int commitCount) {
 	}
 
 	/**
-	 * Returns the time that this execution ended
+	 * Returns the time that this execution ended or {@code null} if the step is running.
 	 *
-	 * @return the time that this execution ended
+	 * @return the time that this execution ended or {@code null} if the step is running
 	 */
+	@Nullable
 	public Date getEndTime() {
 		return endTime;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`/*`
`2`		`- * Copyright 2006-2013 the original author or authors.`
	`2`	`+ * Copyright 2006-2022 the original author or authors.`
`3`	`3`	`*`
`4`	`4`	`* Licensed under the Apache License, Version 2.0 (the "License");`
`5`	`5`	`* you may not use this file except in compliance with the License.`
`@@ -24,6 +24,7 @@`
`24`	`24`	`import java.util.concurrent.CopyOnWriteArrayList;`
`25`	`25`
`26`	`26`	`import org.springframework.batch.item.ExecutionContext;`
	`27`	`+import org.springframework.lang.Nullable;`
`27`	`28`	`import org.springframework.util.Assert;`
`28`	`29`
`29`	`30`	`/**`
`@@ -33,6 +34,7 @@`
`33`	`34`	`*`
`34`	`35`	`* @author Lucas Ward`
`35`	`36`	`* @author Dave Syer`
	`37`	`+ * @author Taeik Lim`
`36`	`38`	`*`
`37`	`39`	`*/`
`38`	`40`	`@SuppressWarnings("serial")`
`@@ -154,10 +156,11 @@ public void setCommitCount(int commitCount) {`
`154`	`156`	`}`
`155`	`157`
`156`	`158`	`/**`
`157`		`- * Returns the time that this execution ended`
	`159`	`+ * Returns the time that this execution ended or {@code null} if the step is running.`
`158`	`160`	`*`
`159`		`- * @return the time that this execution ended`
	`161`	`+ * @return the time that this execution ended or {@code null} if the step is running`
`160`	`162`	`*/`
	`163`	`+ @Nullable`
`161`	`164`	`public Date getEndTime() {`
`162`	`165`	`return endTime;`
`163`	`166`	`}`