sql: Add length to VARCHAR MySQLTypeName string

carlosms · carlosms · commit 0ddfce4dbfba · 2019-10-18T11:38:36.000+01:00
Signed-off-by: Carlos Martín &lt;carlos.martin.sanchez@gmail.com&gt;
diff --git a/sql/plan/show_create_table_test.go b/sql/plan/show_create_table_test.go
@@ -19,6 +19,7 @@ func TestShowCreateTable(t *testing.T) {
 			&sql.Column{Name: "baz", Type: sql.Text, Default: "", Nullable: false},
 			&sql.Column{Name: "zab", Type: sql.Int32, Default: int32(0), Nullable: true},
 			&sql.Column{Name: "bza", Type: sql.Uint64, Default: uint64(0), Nullable: true},
+			&sql.Column{Name: "foo", Type: sql.VarChar(123), Default: "", Nullable: true},
 		})
 
 	db.AddTable(table.Name(), table)
@@ -39,7 +40,9 @@ func TestShowCreateTable(t *testing.T) {
 		table.Name(),
 		"CREATE TABLE `test-table` (\n  `baz` text NOT NULL,\n"+
 			"  `zab` integer DEFAULT 0,\n"+
-			"  `bza` bigint unsigned DEFAULT 0\n) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4",
+			"  `bza` bigint unsigned DEFAULT 0,\n"+
+			"  `foo` varchar(123)\n"+
+			") ENGINE=InnoDB DEFAULT CHARSET=utf8mb4",
 	)
 
 	require.Equal(expected, row)
diff --git a/sql/type.go b/sql/type.go
@@ -1258,7 +1258,7 @@ func MySQLTypeName(t Type) string {
 	case sqltypes.Char:
 		return "CHAR"
 	case sqltypes.VarChar:
-		return "VARCHAR"
+		return fmt.Sprintf("VARCHAR(%v)", t.(varCharT).Capacity())
 	case sqltypes.Text:
 		return "TEXT"
 	case sqltypes.Bit:
