Skip to content

Commit 6e60087

Browse files
authored
Merge pull request #2502 from nocnokneo/patch-1
Remove atomicity warning that does not apply to STM32
2 parents 0935852 + 0f14ef8 commit 6e60087

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
Please, Make sure that your PR is not a duplicate.
44
Search among the [Pull request](https://github.com/stm32duino/Arduino_Core_STM32/pulls) before creating one.
55

6-
IMPORTANT: Please review the [CONTRIBUTING.md](../CONTRIBUTING.md) file for detailed contributing guidelines.
6+
IMPORTANT: Please review the [CONTRIBUTING.md](https://github.com/stm32duino/Arduino_Core_STM32/blob/main/CONTRIBUTING.md) file for detailed contributing guidelines.
77

88
Thanks for submitting a pull request.
99
Please provide enough information so that others can review your pull request:

cores/arduino/HardwareSerial.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,6 @@
3535
// location from which to read.
3636
// NOTE: a "power of 2" buffer size is recommended to dramatically
3737
// optimize all the modulo operations for ring buffers.
38-
// WARNING: When buffer sizes are increased to > 256, the buffer index
39-
// variables are automatically increased in size, but the extra
40-
// atomicity guards needed for that are not implemented. This will
41-
// often work, but occasionally a race condition can occur that makes
42-
// Serial behave erratically. See https://github.com/arduino/Arduino/issues/2405
4338
#if !defined(SERIAL_TX_BUFFER_SIZE)
4439
#define SERIAL_TX_BUFFER_SIZE 64
4540
#endif

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy