Don't pass opener/referer info, and add info icon

ghengeveld · ghengeveld · commit 4b17eacfbe3a · 2025-05-14T14:44:33.000+02:00
diff --git a/code/addons/a11y/src/components/A11yContext.tsx b/code/addons/a11y/src/components/A11yContext.tsx
@@ -215,10 +215,9 @@ export const A11yContextProvider: FC<PropsWithChildren> = (props) => {
   const handleSelect = useCallback(
     (itemId: string, details: ClickEventDetails) => {
       const [type, id] = itemId.split('.');
+      const result = results?.[type as RuleType]?.find((r) => r.id === id);
       const index =
-        results?.[type as RuleType]
-          ?.find((r) => r.id === id)
-          ?.nodes.findIndex((n) => details.selectors.some((s) => s === String(n.target))) ?? -1;
+        result?.nodes.findIndex((n) => details.selectors.some((s) => s === String(n.target))) ?? -1;
       if (index !== -1) {
         const key = `${type}.${id}.${index + 1}`;
         setSelectedItems(new Map([[`${type}.${id}`, key]]));
@@ -338,6 +337,7 @@ export const A11yContextProvider: FC<PropsWithChildren> = (props) => {
           },
           {
             id: `${tab}.${result.id}`,
+            icon: 'info',
             title: 'View more details',
             clickEvent: EVENTS.SELECT,
             selectors,
@@ -376,6 +376,7 @@ export const A11yContextProvider: FC<PropsWithChildren> = (props) => {
           },
           {
             id: `${tab}.${result.id}`,
+            icon: 'info',
             title: 'View more details',
             clickEvent: EVENTS.SELECT,
             selectors,
diff --git a/code/addons/a11y/src/components/Report/Details.tsx b/code/addons/a11y/src/components/Report/Details.tsx
@@ -143,7 +143,7 @@ export const Details = ({ id, item, type, selection, handleSelectionChange }: De
       <RuleId>{item.id}</RuleId>
       <Description>
         {getFriendlySummaryForAxeResult(item)}{' '}
-        <Link href={item.helpUrl} target="_blank" withArrow>
+        <Link href={item.helpUrl} target="_blank" rel="noopener noreferrer" withArrow>
           Learn how to resolve this violation
         </Link>
       </Description>
