fix: Enhance error handling in factorial function (TheAlgorithms#1430)

yongeazi143 · web-flow · commit 96d122f29e3e · 2023-10-05T15:30:28.000+05:30
diff --git a/Recursive/Factorial.js b/Recursive/Factorial.js
@@ -9,17 +9,14 @@
  */
 
 const factorial = (n) => {
-  if (!Number.isInteger(n)) {
-    throw new RangeError('Not a Whole Number')
-  }
-
-  if (n < 0) {
-    throw new RangeError('Not a Positive Number')
+  if (!Number.isInteger(n) || n < 0) {
+    throw new RangeError('Input should be a non-negative whole number')
   }
 
   if (n === 0) {
     return 1
   }
+
   return n * factorial(n - 1)
 }
 
diff --git a/Recursive/test/Factorial.test.js b/Recursive/test/Factorial.test.js
@@ -10,10 +10,20 @@ describe('Factorial', () => {
   })
 
   it('Throw Error for Invalid Input', () => {
-    expect(() => factorial('-')).toThrow('Not a Whole Number')
-    expect(() => factorial(null)).toThrow('Not a Whole Number')
-    expect(() => factorial(undefined)).toThrow('Not a Whole Number')
-    expect(() => factorial(3.142)).toThrow('Not a Whole Number')
-    expect(() => factorial(-1)).toThrow('Not a Positive Number')
+    expect(() => factorial('-')).toThrow(
+      'Input should be a non-negative whole number'
+    )
+    expect(() => factorial(null)).toThrow(
+      'Input should be a non-negative whole number'
+    )
+    expect(() => factorial(undefined)).toThrow(
+      'Input should be a non-negative whole number'
+    )
+    expect(() => factorial(3.142)).toThrow(
+      'Input should be a non-negative whole number'
+    )
+    expect(() => factorial(-1)).toThrow(
+      'Input should be a non-negative whole number'
+    )
   })
 })

Original file line number	Diff line number	Diff line change
`@@ -9,17 +9,14 @@`
`9`	`9`	`*/`
`10`	`10`
`11`	`11`	`const factorial = (n) => {`
`12`		`- if (!Number.isInteger(n)) {`
`13`		`- throw new RangeError('Not a Whole Number')`
`14`		`- }`
`15`		`-`
`16`		`- if (n < 0) {`
`17`		`- throw new RangeError('Not a Positive Number')`
	`12`	`+ if (!Number.isInteger(n) \|\| n < 0) {`
	`13`	`+ throw new RangeError('Input should be a non-negative whole number')`
`18`	`14`	`}`
`19`	`15`
`20`	`16`	`if (n === 0) {`
`21`	`17`	`return 1`
`22`	`18`	`}`
	`19`	`+`
`23`	`20`	`return n * factorial(n - 1)`
`24`	`21`	`}`
`25`	`22`