fix: handle booleanish popover (#2702)

dummdidumm · web-flow · commit 59796de2cfb5 · 2025-03-06T13:14:48.000+01:00
`<div popover></div>` actually means `<div popover=""></div>` #2688
diff --git a/packages/svelte2tsx/src/htmlxtojsx_v2/nodes/Attribute.ts b/packages/svelte2tsx/src/htmlxtojsx_v2/nodes/Attribute.ts
@@ -160,7 +160,7 @@ export function handleAttribute(
     const attributeValue: TransformationArray = [];
 
     if (attr.value === true) {
-        attributeValue.push('true');
+        attributeValue.push(attr.name === 'popover' ? '""' : 'true');
         addAttribute(attributeName, attributeValue);
         return;
     }
diff --git a/packages/svelte2tsx/test/htmlx2jsx/samples/attribute-bare/expectedv2.js b/packages/svelte2tsx/test/htmlx2jsx/samples/attribute-bare/expectedv2.js
@@ -1 +1,5 @@
-  { const $$_tnenopmoCemoS0C = __sveltets_2_ensureComponent(SomeComponent); new $$_tnenopmoCemoS0C({ target: __sveltets_2_any(), props: {"relaxed":true,}});}
+  { const $$_tnenopmoCemoS0C = __sveltets_2_ensureComponent(SomeComponent); new $$_tnenopmoCemoS0C({ target: __sveltets_2_any(), props: {"relaxed":true,}});}
+ { svelteHTML.createElement("input", {"disabled":true,});}
+
+
+ { svelteHTML.createElement("div", {"popover":"",}); }
diff --git a/packages/svelte2tsx/test/htmlx2jsx/samples/attribute-bare/input.svelte b/packages/svelte2tsx/test/htmlx2jsx/samples/attribute-bare/input.svelte
@@ -1 +1,5 @@
-<SomeComponent relaxed />
+<SomeComponent relaxed />
+<input disabled>
+
+<!-- special: this actually means popover="" -->
+<div popover></div>

Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,7 @@ export function handleAttribute(`
`160`	`160`	`const attributeValue: TransformationArray = [];`
`161`	`161`
`162`	`162`	`if (attr.value === true) {`
`163`		`- attributeValue.push('true');`
	`163`	`+ attributeValue.push(attr.name === 'popover' ? '""' : 'true');`
`164`	`164`	`addAttribute(attributeName, attributeValue);`
`165`	`165`	`return;`
`166`	`166`	`}`