fix: ignore mutation validation for props that are not proxies in more cases (#15759)

dummdidumm · web-flow · commit 26e574f27f68 · 2025-04-14T08:57:37.000-04:00
This fixes an off-by-one error - we did not bail if the top level of the prop wasn't a state already. Fixes #15727
diff --git a/.changeset/modern-ducks-reflect.md b/.changeset/modern-ducks-reflect.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: ignore mutation validation for props that are not proxies in more cases
diff --git a/packages/svelte/src/internal/client/dev/ownership.js b/packages/svelte/src/internal/client/dev/ownership.js
@@ -31,13 +31,14 @@ export function create_ownership_validator(props) {
 				return result;
 			}
 
-			let value = props[name];
+			/** @type {any} */
+			let value = props;
 
-			for (let i = 1; i < path.length - 1; i++) {
+			for (let i = 0; i < path.length - 1; i++) {
+				value = value[path[i]];
 				if (!value?.[STATE_SYMBOL]) {
 					return result;
 				}
-				value = value[path[i]];
 			}
 
 			const location = sanitize_location(`${component[FILENAME]}:${line}:${column}`);
diff --git a/packages/svelte/tests/runtime-runes/samples/non-local-mutation-ok/_config.js b/packages/svelte/tests/runtime-runes/samples/non-local-mutation-ok/_config.js
@@ -0,0 +1,18 @@
+import { flushSync } from 'svelte';
+import { test } from '../../test';
+
+export default test({
+	compileOptions: {
+		dev: true
+	},
+
+	test({ assert, target, warnings }) {
+		const btn = target.querySelector('button');
+		btn?.click();
+		flushSync();
+
+		assert.deepEqual(warnings, []);
+	},
+
+	warnings: []
+});
diff --git a/packages/svelte/tests/runtime-runes/samples/non-local-mutation-ok/child.svelte b/packages/svelte/tests/runtime-runes/samples/non-local-mutation-ok/child.svelte
@@ -0,0 +1,8 @@
+<script>
+	let { klass, getter_setter } = $props();
+</script>
+
+<button onclick={() => {
+	klass.y = 2;
+	getter_setter.y = 2;
+}}>mutate</button>
diff --git a/packages/svelte/tests/runtime-runes/samples/non-local-mutation-ok/main.svelte b/packages/svelte/tests/runtime-runes/samples/non-local-mutation-ok/main.svelte
@@ -0,0 +1,21 @@
+<script>
+	import Child from './child.svelte';
+
+	class X {
+		y = $state(1);
+	}
+
+	const klass = new X();
+
+	let y = $state(1);
+	const getter_setter = {
+		get y() {
+			return y;
+		},
+		set y(value) {
+			y = value;
+		}
+	}
+</script>
+
+<Child {klass}  {getter_setter} />

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'svelte': patch
 +---
++
 +fix: ignore mutation validation for props that are not proxies in more cases
Original file line number	Diff line number	Diff line change
`@@ -31,13 +31,14 @@ export function create_ownership_validator(props) {`
`31`	`31`	`return result;`
`32`	`32`	`}`
`33`	`33`
`34`		`- let value = props[name];`
	`34`	`+ /** @type {any} */`
	`35`	`+ let value = props;`
`35`	`36`
`36`		`- for (let i = 1; i < path.length - 1; i++) {`
	`37`	`+ for (let i = 0; i < path.length - 1; i++) {`
	`38`	`+ value = value[path[i]];`
`37`	`39`	`if (!value?.[STATE_SYMBOL]) {`
`38`	`40`	`return result;`
`39`	`41`	`}`
`40`		`- value = value[path[i]];`
`41`	`42`	`}`
`42`	`43`
`43`	`44`	const location = sanitize_location(`${component[FILENAME]}:${line}:${column}`);