chore: default params for html blocks (#15778)

Rich-Harris · web-flow · commit 2db5bccde32c · 2025-04-16T18:22:21.000-04:00
* chore: default params for html blocks

* fix

* changeset

* update test
diff --git a/.changeset/chatty-apples-flash.md b/.changeset/chatty-apples-flash.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+chore: default params for html blocks
diff --git a/packages/svelte/src/compiler/phases/3-transform/client/visitors/HtmlTag.js b/packages/svelte/src/compiler/phases/3-transform/client/visitors/HtmlTag.js
@@ -11,17 +11,22 @@ import * as b from '../../../../utils/builders.js';
 export function HtmlTag(node, context) {
 	context.state.template.push('<!>');
 
-	// push into init, so that bindings run afterwards, which might trigger another run and override hydration
-	context.state.init.push(
-		b.stmt(
-			b.call(
-				'$.html',
-				context.state.node,
-				b.thunk(/** @type {Expression} */ (context.visit(node.expression))),
-				b.literal(context.state.metadata.namespace === 'svg'),
-				b.literal(context.state.metadata.namespace === 'mathml'),
-				is_ignored(node, 'hydration_html_changed') && b.true
-			)
+	const expression = /** @type {Expression} */ (context.visit(node.expression));
+
+	const is_svg = context.state.metadata.namespace === 'svg';
+	const is_mathml = context.state.metadata.namespace === 'mathml';
+
+	const statement = b.stmt(
+		b.call(
+			'$.html',
+			context.state.node,
+			b.thunk(expression),
+			is_svg && b.true,
+			is_mathml && b.true,
+			is_ignored(node, 'hydration_html_changed') && b.true
 		)
 	);
+
+	// push into init, so that bindings run afterwards, which might trigger another run and override hydration
+	context.state.init.push(statement);
 }
diff --git a/packages/svelte/src/internal/client/dom/blocks/html.js b/packages/svelte/src/internal/client/dom/blocks/html.js
@@ -34,12 +34,12 @@ function check_hash(element, server_hash, value) {
 /**
  * @param {Element | Text | Comment} node
  * @param {() => string} get_value
- * @param {boolean} svg
- * @param {boolean} mathml
+ * @param {boolean} [svg]
+ * @param {boolean} [mathml]
  * @param {boolean} [skip_warning]
  * @returns {void}
  */
-export function html(node, get_value, svg, mathml, skip_warning) {
+export function html(node, get_value, svg = false, mathml = false, skip_warning = false) {
 	var anchor = node;
 
 	var value = '';
diff --git a/packages/svelte/tests/snapshot/samples/skip-static-subtree/_expected/client/index.svelte.js b/packages/svelte/tests/snapshot/samples/skip-static-subtree/_expected/client/index.svelte.js
@@ -13,7 +13,7 @@ export default function Skip_static_subtree($$anchor, $$props) {
 
 	var node = $.sibling(h1, 10);
 
-	$.html(node, () => $$props.content, false, false);
+	$.html(node, () => $$props.content);
 	$.next(14);
 	$.reset(main);
 

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'svelte': patch
 +---
++
 +chore: default params for html blocks