rune_invalid_arguments_length

adiguba · adiguba · commit 46547aecbd42 · 2025-03-15T07:12:23.000+01:00
diff --git a/.changeset/two-spies-lie.md b/.changeset/two-spies-lie.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: throw rune_invalid_arguments_length when $state.raw() is used with more than 1 arg
diff --git a/packages/svelte/src/compiler/phases/2-analyze/visitors/CallExpression.js b/packages/svelte/src/compiler/phases/2-analyze/visitors/CallExpression.js
@@ -117,7 +117,7 @@ export function CallExpression(node, context) {
 
 			if ((rune === '$derived' || rune === '$derived.by') && node.arguments.length !== 1) {
 				e.rune_invalid_arguments_length(node, rune, 'exactly one argument');
-			} else if (rune === '$state' && node.arguments.length > 1) {
+			} else if (node.arguments.length > 1) {
 				e.rune_invalid_arguments_length(node, rune, 'zero or one arguments');
 			}
 
diff --git a/packages/svelte/tests/compiler-errors/samples/runes-wrong-state-raw-args/_config.js b/packages/svelte/tests/compiler-errors/samples/runes-wrong-state-raw-args/_config.js
@@ -0,0 +1,8 @@
+import { test } from '../../test';
+
+export default test({
+	error: {
+		code: 'rune_invalid_arguments_length',
+		message: '`$state.raw` must be called with zero or one arguments'
+	}
+});
diff --git a/packages/svelte/tests/compiler-errors/samples/runes-wrong-state-raw-args/main.svelte b/packages/svelte/tests/compiler-errors/samples/runes-wrong-state-raw-args/main.svelte
@@ -0,0 +1,3 @@
+<script>
+	const foo = $state.raw(1, 2, 3);
+</script>
diff --git a/packages/svelte/tests/compiler-errors/samples/runes-wrong-state-raw-args/main.svelte.js b/packages/svelte/tests/compiler-errors/samples/runes-wrong-state-raw-args/main.svelte.js
@@ -0,0 +1 @@
+const foo = $state.raw(1, 2, 3);

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'svelte': patch
 +---
++
 +fix: throw rune_invalid_arguments_length when $state.raw() is used with more than 1 arg
Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ export function CallExpression(node, context) {`
`117`	`117`
`118`	`118`	`if ((rune === '$derived' \|\| rune === '$derived.by') && node.arguments.length !== 1) {`
`119`	`119`	`e.rune_invalid_arguments_length(node, rune, 'exactly one argument');`
`120`		`- } else if (rune === '$state' && node.arguments.length > 1) {`
	`120`	`+ } else if (node.arguments.length > 1) {`
`121`	`121`	`e.rune_invalid_arguments_length(node, rune, 'zero or one arguments');`
`122`	`122`	`}`
`123`	`123`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+<script>`
	`2`	`+ const foo = $state.raw(1, 2, 3);`
	`3`	`+</script>`