put equality statements first, it's faster

Rich-Harris · Rich-Harris · commit e2ba9ef25565 · 2025-07-02T19:11:10.000-04:00
diff --git a/packages/svelte/src/internal/client/reactivity/sources.js b/packages/svelte/src/internal/client/reactivity/sources.js
@@ -140,7 +140,7 @@ export function set(source, value, should_proxy = false) {
 		(!untracking || (active_reaction.f & INSPECT_EFFECT) !== 0) &&
 		is_runes() &&
 		(active_reaction.f & (DERIVED | BLOCK_EFFECT | INSPECT_EFFECT)) !== 0 &&
-		!(source_ownership?.sources.includes(source) && source_ownership.reaction === active_reaction)
+		!(source_ownership?.reaction === active_reaction && source_ownership.sources.includes(source))
 	) {
 		e.state_unsafe_mutation();
 	}
diff --git a/packages/svelte/src/internal/client/runtime.js b/packages/svelte/src/internal/client/runtime.js
@@ -235,8 +235,12 @@ function schedule_possible_effect_self_invalidation(signal, effect, root = true)
 	for (var i = 0; i < reactions.length; i++) {
 		var reaction = reactions[i];
 
-		if (source_ownership?.sources.includes(signal) && source_ownership.reaction === active_reaction)
+		if (
+			source_ownership?.reaction === active_reaction &&
+			source_ownership.sources.includes(signal)
+		) {
 			continue;
+		}
 
 		if ((reaction.f & DERIVED) !== 0) {
 			schedule_possible_effect_self_invalidation(/** @type {Derived} */ (reaction), effect, false);
@@ -741,8 +745,8 @@ export function get(signal) {
 	// Register the dependency on the current reaction signal.
 	if (active_reaction !== null && !untracking) {
 		if (
-			!source_ownership?.sources.includes(signal) ||
-			source_ownership.reaction !== active_reaction
+			source_ownership?.reaction !== active_reaction ||
+			!source_ownership?.sources.includes(signal)
 		) {
 			var deps = active_reaction.deps;
 			if (signal.rv < read_version) {

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ export function set(source, value, should_proxy = false) {`
`140`	`140`	`(!untracking \|\| (active_reaction.f & INSPECT_EFFECT) !== 0) &&`
`141`	`141`	`is_runes() &&`
`142`	`142`	`(active_reaction.f & (DERIVED \| BLOCK_EFFECT \| INSPECT_EFFECT)) !== 0 &&`
`143`		`- !(source_ownership?.sources.includes(source) && source_ownership.reaction === active_reaction)`
	`143`	`+ !(source_ownership?.reaction === active_reaction && source_ownership.sources.includes(source))`
`144`	`144`	`) {`
`145`	`145`	`e.state_unsafe_mutation();`
`146`	`146`	`}`