From e8a7c426d4f80afca31821997ef412824831328b Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Wed, 11 Jun 2025 19:38:10 -0400 Subject: [PATCH 1/3] remove errant log --- .../runtime-runes/samples/flush-sync-no-scheduled/_config.js | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/svelte/tests/runtime-runes/samples/flush-sync-no-scheduled/_config.js b/packages/svelte/tests/runtime-runes/samples/flush-sync-no-scheduled/_config.js index 33a59dfbd348..85e06fa8ec11 100644 --- a/packages/svelte/tests/runtime-runes/samples/flush-sync-no-scheduled/_config.js +++ b/packages/svelte/tests/runtime-runes/samples/flush-sync-no-scheduled/_config.js @@ -5,7 +5,6 @@ export default test({ const btn = target.querySelector('button'); const main = target.querySelector('main'); ok(main); - console.log(main.innerHTML); assert.htmlEqual(main.innerHTML, `
true
`); // we don't want to use flush sync (or tick that use it inside) since we are testing that calling `flushSync` once // when there are no scheduled effects does not cause reactivity to break From f5a020d56bdf07cba501895a496c036172a6d995 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Wed, 11 Jun 2025 20:26:45 -0400 Subject: [PATCH 2/3] fix: correctly tag private class state fields (#16132) --- .changeset/three-steaks-wash.md | 5 +++ .../3-transform/client/visitors/ClassBody.js | 2 +- .../samples/inspect-trace-class/_config.js | 31 +++++++++++++++++++ .../samples/inspect-trace-class/main.svelte | 28 +++++++++++++++++ 4 files changed, 65 insertions(+), 1 deletion(-) create mode 100644 .changeset/three-steaks-wash.md create mode 100644 packages/svelte/tests/runtime-runes/samples/inspect-trace-class/_config.js create mode 100644 packages/svelte/tests/runtime-runes/samples/inspect-trace-class/main.svelte diff --git a/.changeset/three-steaks-wash.md b/.changeset/three-steaks-wash.md new file mode 100644 index 000000000000..caf0ea2bfe35 --- /dev/null +++ b/.changeset/three-steaks-wash.md @@ -0,0 +1,5 @@ +--- +'svelte': patch +--- + +fix: correctly tag private class state fields diff --git a/packages/svelte/src/compiler/phases/3-transform/client/visitors/ClassBody.js b/packages/svelte/src/compiler/phases/3-transform/client/visitors/ClassBody.js index e78a8824ddbf..5bd9add2a59e 100644 --- a/packages/svelte/src/compiler/phases/3-transform/client/visitors/ClassBody.js +++ b/packages/svelte/src/compiler/phases/3-transform/client/visitors/ClassBody.js @@ -78,7 +78,7 @@ export function ClassBody(node, context) { ? /** @type {CallExpression} */ (context.visit(definition.value, child_state)) : undefined; - if (dev) { + if (dev && field.node === definition) { value = b.call('$.tag', value, b.literal(`${declaration.id?.name ?? '[class]'}.${name}`)); } diff --git a/packages/svelte/tests/runtime-runes/samples/inspect-trace-class/_config.js b/packages/svelte/tests/runtime-runes/samples/inspect-trace-class/_config.js new file mode 100644 index 000000000000..98b3fb6cbce3 --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/inspect-trace-class/_config.js @@ -0,0 +1,31 @@ +import { flushSync } from 'svelte'; +import { test } from '../../test'; +import { normalise_trace_logs } from '../../../helpers.js'; + +export default test({ + compileOptions: { + dev: true + }, + + test({ assert, target, logs }) { + assert.deepEqual(normalise_trace_logs(logs), [ + { log: 'effect' }, + { log: '$state', highlighted: true }, + { log: 'Counter.#count', highlighted: false }, + { log: 0 } + ]); + + logs.length = 0; + + const button = target.querySelector('button'); + button?.click(); + flushSync(); + + assert.deepEqual(normalise_trace_logs(logs), [ + { log: 'effect' }, + { log: '$state', highlighted: true }, + { log: 'Counter.#count', highlighted: false }, + { log: 1 } + ]); + } +}); diff --git a/packages/svelte/tests/runtime-runes/samples/inspect-trace-class/main.svelte b/packages/svelte/tests/runtime-runes/samples/inspect-trace-class/main.svelte new file mode 100644 index 000000000000..56bd497e0955 --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/inspect-trace-class/main.svelte @@ -0,0 +1,28 @@ + + + From f0497b15ee48b477f5213faff335a68e960e8f7d Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed, 11 Jun 2025 20:55:51 -0400 Subject: [PATCH 3/3] Version Packages (#16133) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- .changeset/three-steaks-wash.md | 5 ----- packages/svelte/CHANGELOG.md | 6 ++++++ packages/svelte/package.json | 2 +- packages/svelte/src/version.js | 2 +- 4 files changed, 8 insertions(+), 7 deletions(-) delete mode 100644 .changeset/three-steaks-wash.md diff --git a/.changeset/three-steaks-wash.md b/.changeset/three-steaks-wash.md deleted file mode 100644 index caf0ea2bfe35..000000000000 --- a/.changeset/three-steaks-wash.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'svelte': patch ---- - -fix: correctly tag private class state fields diff --git a/packages/svelte/CHANGELOG.md b/packages/svelte/CHANGELOG.md index 34e1c2fc6e1a..23d834108a95 100644 --- a/packages/svelte/CHANGELOG.md +++ b/packages/svelte/CHANGELOG.md @@ -1,5 +1,11 @@ # svelte +## 5.34.1 + +### Patch Changes + +- fix: correctly tag private class state fields ([#16132](https://github.com/sveltejs/svelte/pull/16132)) + ## 5.34.0 ### Minor Changes diff --git a/packages/svelte/package.json b/packages/svelte/package.json index e412a5a7416c..83d5b8c3e6ca 100644 --- a/packages/svelte/package.json +++ b/packages/svelte/package.json @@ -2,7 +2,7 @@ "name": "svelte", "description": "Cybernetically enhanced web apps", "license": "MIT", - "version": "5.34.0", + "version": "5.34.1", "type": "module", "types": "./types/index.d.ts", "engines": { diff --git a/packages/svelte/src/version.js b/packages/svelte/src/version.js index 42f59dffada9..2d603694d2b7 100644 --- a/packages/svelte/src/version.js +++ b/packages/svelte/src/version.js @@ -4,5 +4,5 @@ * The current version, as set in package.json. * @type {string} */ -export const VERSION = '5.34.0'; +export const VERSION = '5.34.1'; export const PUBLIC_VERSION = '5'; pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy