fix: incorrect runes inference when having empty compiler options (#561)

ota-meshi · web-flow · commit 8350bb5b59bc · 2024-09-13T14:18:12.000+09:00
diff --git a/.changeset/late-poems-collect.md b/.changeset/late-poems-collect.md
@@ -0,0 +1,5 @@
+---
+"svelte-eslint-parser": patch
+---
+
+fix: incorrect runes inference when having empty compiler options
diff --git a/src/svelte-config/parser.ts b/src/svelte-config/parser.ts
@@ -62,15 +62,15 @@ function parseSvelteConfigExpression(
   if (compilerOptions?.type === EvaluatedType.object) {
     result.compilerOptions = {};
     const runes = compilerOptions.getProperty("runes")?.getStatic();
-    if (runes) {
+    if (runes?.value != null) {
       result.compilerOptions.runes = Boolean(runes.value);
     }
   }
   const kit = evaluated.getProperty("kit");
   if (kit?.type === EvaluatedType.object) {
     result.kit = {};
     const files = kit.getProperty("files")?.getStatic();
-    if (files) result.kit.files = files.value as never;
+    if (files?.value != null) result.kit.files = files.value as never;
   }
   return result;
 }
diff --git a/tests/src/svelte-config/parser.ts b/tests/src/svelte-config/parser.ts
@@ -60,6 +60,12 @@ describe("parseConfig", () => {
         `,
       output: { compilerOptions: { runes: true } },
     },
+    {
+      code: `
+        export default {compilerOptions:{}}
+        `,
+      output: { compilerOptions: {} },
+    },
   ];
   for (const { code, output } of testCases) {
     it(code, () => {

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"svelte-eslint-parser": patch
 +---
++
 +fix: incorrect runes inference when having empty compiler options
Original file line number	Diff line number	Diff line change
`@@ -62,15 +62,15 @@ function parseSvelteConfigExpression(`
`62`	`62`	`if (compilerOptions?.type === EvaluatedType.object) {`
`63`	`63`	`result.compilerOptions = {};`
`64`	`64`	`const runes = compilerOptions.getProperty("runes")?.getStatic();`
`65`		`- if (runes) {`
	`65`	`+ if (runes?.value != null) {`
`66`	`66`	`result.compilerOptions.runes = Boolean(runes.value);`
`67`	`67`	`}`
`68`	`68`	`}`
`69`	`69`	`const kit = evaluated.getProperty("kit");`
`70`	`70`	`if (kit?.type === EvaluatedType.object) {`
`71`	`71`	`result.kit = {};`
`72`	`72`	`const files = kit.getProperty("files")?.getStatic();`
`73`		`- if (files) result.kit.files = files.value as never;`
	`73`	`+ if (files?.value != null) result.kit.files = files.value as never;`
`74`	`74`	`}`
`75`	`75`	`return result;`
`76`	`76`	`}`