remove console.log, allow explicit sorting of scale domain

gka · gka · commit eef07d7d8533 · 2025-05-31T22:34:36.000+02:00
diff --git a/src/lib/helpers/scales.ts b/src/lib/helpers/scales.ts
@@ -184,10 +184,10 @@ export function createScale<T extends ScaleOptions>(
         // we're deliberately checking for !== undefined and not for != null
         // since the explicit sort transforms like shuffle will set the
         // sort channel to null to we know that there's an explicit order
-        if (name === 'y') console.log(mark.type, mark.options[IS_SORTED]);
-        if (mark.options[IS_SORTED] != null) {
+        if ((name === 'x' || name === 'y') && mark.options[IS_SORTED] != undefined) {
             sortOrdinalDomain = false;
         }
+
         for (const channel of mark.channels) {
             // channelOptions can be passed as prop, but most often users will just
             // pass the channel accessor or constant value, so we may need to wrap
@@ -282,6 +282,10 @@ export function createScale<T extends ScaleOptions>(
         }
     }
 
+    if ((name === 'x' || name === 'y') && scaleOptions.sort) {
+        sortOrdinalDomain = true;
+    }
+
     // construct domain from data values
     const valueArr = [...dataValues.values(), ...(scaleOptions.domain || [])].filter(
         (d) => d != null
