Fix/use unknown color #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-104
# or install the specific version
npm install svelteplot@0.2.9-pr-104.0 |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-104
# or install the specific version
npm install svelteplot@0.2.9-pr-104.1 |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-104
# or install the specific version
npm install svelteplot@0.2.9-pr-104.2 |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-104
# or install the specific version
npm install svelteplot@0.2.9-pr-104.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #100
unknowncolor value (#cccccc99) for invalid data, ensuring better visual distinction in plots. (src/lib/core/Plot.svelte, [1] [2]Mark.svelteto improve handling of invalid data points. (src/lib/Mark.svelte, src/lib/Mark.svelteL261-R271)Dotmarks from "dots" to "dot" for better consistency. (src/lib/marks/Dot.svelte, src/lib/marks/Dot.svelteL87-R86)Examples and Documentation:
Dotmarks. (src/routes/examples/dot/bubble-matrix.svelte, src/routes/examples/dot/bubble-matrix.svelteR1-R27)src/routes/+page.md, src/routes/+page.mdL8-R15)Testing Infrastructure Updates:
New Tests:
Dotmarks, validating rendering, scaling, and color mapping based on data. (src/tests/dot.test.svelte, [1];src/tests/dot.test.ts, [2]Utility Functions:
getRectDims,getPathDims,getTranslate) for extracting dimensions and transformations from SVG elements, improving test reliability and modularity. (src/tests/utils.ts, src/tests/utils.tsR1-R40)BarXtests to replace inline dimension calculation functions with the new utility functions. (src/tests/barX.test.ts, [1] [2]Code Quality Improvements:
ESLint Configuration:
console.logwhile permittingconsole.error. (eslint.config.js, eslint.config.jsR6-R16)svelte/no-inspectrule to warn against using the inspect directive in Svelte files. (eslint.config.js, eslint.config.jsR6-R16)Refactoring:
updateMark,updatePlotState) fromMark.svelteto streamline the codebase. (src/lib/Mark.svelte, src/lib/Mark.svelteL59-R59)ColorLegendstyling to include column gaps for better spacing. (src/lib/marks/ColorLegend.svelte, src/lib/marks/ColorLegend.svelteR170)