feat: add text.lineHeight + support css variable font sizes #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a new lineHeight text option and CSS variable font sizes, enhancing how text is rendered and positioned.
- Updated documentation to describe the new lineHeight option.
- Introduced an example showcasing CSS variable usage for font sizes in a Svelte component.
- Refactored text rendering by extracting multiline text logic into a helper component.
Reviewed Changes
Copilot reviewed 78 out of 78 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/routes/marks/text/+page.md | Updated text options documentation with a new lineHeight property and clarified positioning channels. |
| src/routes/examples/text/css-var.svelte | Added an example demonstrating CSS variable-driven font size usage. |
| src/lib/marks/helpers/MultilineText.svelte | Introduced a new helper to handle multiline text, incorporating lineHeight support. |
| src/lib/marks/Text.svelte | Updated to use the new MultilineText helper and set default lineHeight. |
| src/lib/helpers/resolve.ts | Minor code refactoring. |
| src/lib/helpers/getBaseStyles.ts | Added helper functions to interpret pixel and rem values. |
Comments suppressed due to low confidence (1)
src/lib/marks/helpers/MultilineText.svelte:117
- The default lineHeight value is set to 1.2 here, while the documentation and the defaults in Text.svelte suggest a value of 1.1. Consider aligning the default values across components to ensure consistent behavior.
const lineHeight = $derived( textLines.length > 1 ? (resolveProp(args.lineHeight, d.datum) ?? 1.2) : 0 )
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-115
# or install the specific version
npm install svelteplot@0.3.3-pr-115.0 |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-115
# or install the specific version
npm install svelteplot@0.3.3-pr-115.1 |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-115
# or install the specific version
npm install svelteplot@0.3.3-pr-115.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves support for multiline text, CSS variables for font size and line height,
Enhancements to text rendering:
Support for multiline text and line height customization:
lineHeightproperty toText.svelte, allowing users to specify line height as a multiplier of font size. Default value set to1.2.Support for CSS variables in font size and line height:
maybeFromPixelandmaybeFromRemto convert CSS values (e.g.,pxandrem) into numerical values.text/css-var.svelte) demonstrating the use of CSS variables for font size and line height in SVG text rendering.