Remove some unused imports #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR removes unused imports across various Svelte components and helper modules to clean up the codebase.
- Removed redundant imports from Svelte, D3, and internal helper/type modules.
- Simplified helper files by dropping unused functions from imports.
- Updated test files to align with removed type imports.
Reviewed Changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/marks/helpers/BaseAxisY.svelte | Dropped unused tick import from Svelte |
| src/lib/marks/Rect.svelte | Removed unused resolve and event helpers |
| src/lib/marks/GridY.svelte | Removed unused DataRecord type import |
| src/lib/marks/Geo.svelte | Dropped unused FacetContext and UsedScales types |
| src/lib/marks/Dot.svelte | Removed unused testFilter import |
| src/lib/marks/DifferenceY.svelte | Dropped unused ConstantAccessor import |
| src/lib/marks/ColorLegend.svelte | Removed duplicate symbol import |
| src/lib/marks/CellX.svelte | Dropped unused recordizeX import |
| src/lib/marks/AxisY.svelte | Removed unused DataRecord and getBaseStyles imports |
| src/lib/marks/Arrow.svelte | Dropped unused FacetContext import |
| src/lib/helpers/scales.ts | Removed unused d3Range import |
| src/lib/helpers/resolve.ts | Dropped unused pick import |
| src/lib/helpers/reduce.ts | Removed unused quantile and type imports |
| src/lib/helpers/reduce.test.ts | Removed unused RawValue type import |
| src/lib/helpers/projection.ts | Dropped unused isValid import |
| src/lib/helpers/index.ts | Removed unused BaseMarkProps type import |
| src/lib/helpers/index.test.ts | Removed unused pick import |
| src/lib/helpers/facets.ts | Removed unused PlotScale type import |
| src/lib/core/FacetGrid.svelte | Dropped unused setContext import |
| src/lib/core/Facet.svelte | Removed unused PlotScale import |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.