fix test in interval.test.ts for machines in BST #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
In Observable Plot you have the choice between using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time
2025-04-16T23:00:00ZisThu Apr 17 2025 00:00:00 GMT+0100 (British Summer Time).When the test is run on a machine with the timezone set to BST, the test fails as this time is at midnight in BST, so it lies exactly on a day boundary, so
item.__x1anditem.xare equal.The test would also pass if a minute or seconds offset was applied to the test time, so it didn't correspond to exactly midnight (adding an offset of an integer number of hours would fix the issue for systems running BST, but create a problem for some other timezone).
(Possibly there is actually a bug, and the intervals should be constructed by using midnight UTC as the day boundary, igoring the system timezone - I'm not sure what the correct expected behaviour is).