Skip to content

chore: fix mark property types + linting issues #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
May 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
35cc427
refine graticule mark props
gka May 25, 2025
a682816
refine area mark prop types
gka May 25, 2025
7ab586b
refine & export arrow mark props
gka May 25, 2025
fcdc48f
refine & export axisX mark props
gka May 25, 2025
474f50d
bump dependencies
gka May 25, 2025
f853d54
code formatting
gka May 25, 2025
6cee752
chore: fix eslint errors
gka May 25, 2025
a0877dc
chore: fix more lint errors
gka May 25, 2025
9897afa
add lint workflow
gka May 25, 2025
adbe036
chore: refine & export axisY and bar mark prop types
gka May 25, 2025
dabc567
chore: refine & export bollinger mark prop types
gka May 25, 2025
bc7c07e
add interval to barX prop type
gka May 25, 2025
3883ccf
add @component comments
gka May 25, 2025
ff9a607
add more component comments
gka May 25, 2025
c0c025d
chore: refine & export brush mark prop types
gka May 25, 2025
e130315
chore: refine & export cell mark prop types
gka May 25, 2025
b855719
chore: refine & export differenceY mark prop types
gka May 25, 2025
612d150
chore: refine & export color legend mark prop types
gka May 25, 2025
e1dbb18
chore: refine & export dot mark prop types
gka May 25, 2025
f5a3cf1
chore: refine & export frame mark prop types + use rectpath in frame
gka May 25, 2025
5cd23c4
docs: use borderRadius in frame example
gka May 25, 2025
7aae918
chore: refine & export geo mark prop types
gka May 25, 2025
1e1cb86
formatting + lint
gka May 25, 2025
619f1b0
add frame class
gka May 25, 2025
00d31e9
remove log
gka May 25, 2025
ce240c8
..
gka May 25, 2025
4a43f22
chore: refine & export grid mark prop types
gka May 26, 2025
e27d094
add type for linkable mark props
gka May 26, 2025
4e86084
format
gka May 26, 2025
e5264aa
export line mark props type
gka May 26, 2025
304b801
link mark props
gka May 26, 2025
4608349
rect mark props
gka May 26, 2025
81e2185
stack
gka May 26, 2025
7b45bb0
document rect stacking
gka May 26, 2025
10f1877
fix link
gka May 26, 2025
e773a49
docs: sort marks alphabetically in sidebar
gka May 26, 2025
31f5c3b
ts: export regression mark types
gka May 26, 2025
1ca9cf4
ts: export rule mark props types
gka May 26, 2025
4f81a9e
ts: export spike, vector and sphere mark props types
gka May 26, 2025
13265ac
ts: export text mark props type
gka May 26, 2025
6022452
ts: export tick marks prop types
gka May 26, 2025
a545e47
fix typo
gka May 26, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ about: Suggest an idea or feature for SveltePlot
title: ''
labels: enhancement
assignees: ''

---

**Is your feature request related to a problem? Please describe.**
Expand Down
32 changes: 32 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: Lint Check

on:
push:
branches: [main]
pull_request:
branches: [main]

jobs:
lint:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4

- name: Install pnpm
uses: pnpm/action-setup@v3
with:
version: 10
run_install: false

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '22'
cache: 'pnpm'

- name: Install dependencies
run: pnpm install

- name: Run linting
run: pnpm run lint
54 changes: 27 additions & 27 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -1,32 +1,32 @@
name: Run Tests

on:
push:
branches: [ main ]
pull_request:
branches: [ main ]
push:
branches: [main]
pull_request:
branches: [main]

jobs:
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Install pnpm
uses: pnpm/action-setup@v3
with:
version: 10
run_install: false
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '22'
cache: 'pnpm'
- name: Install dependencies
run: pnpm install
- name: Run Vitest tests
run: pnpm test
test:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4

- name: Install pnpm
uses: pnpm/action-setup@v3
with:
version: 10
run_install: false

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '22'
cache: 'pnpm'

- name: Install dependencies
run: pnpm install

- name: Run Vitest tests
run: pnpm test
4 changes: 2 additions & 2 deletions config/sidebar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,12 @@ export default {
{ title: 'Line', to: '/marks/line' },
{ title: 'Link', to: '/marks/link' },
{ title: 'Pointer', to: '/marks/pointer' },
{ title: 'Vector', to: '/marks/vector' },
{ title: 'Rect', to: '/marks/rect' },
{ title: 'Regression', to: '/marks/regression' },
{ title: 'Rule', to: '/marks/rule' },
{ title: 'Text', to: '/marks/text' },
{ title: 'Tick', to: '/marks/tick' }
{ title: 'Tick', to: '/marks/tick' },
{ title: 'Vector', to: '/marks/vector' }
]
},
{
Expand Down
14 changes: 7 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,13 @@
"@sveltejs/adapter-auto": "^6.0.1",
"@sveltejs/adapter-static": "^3.0.8",
"@sveltejs/eslint-config": "^8.2.0",
"@sveltejs/kit": "^2.21.0",
"@sveltejs/kit": "^2.21.1",
"@sveltejs/package": "^2.3.11",
"@sveltejs/vite-plugin-svelte": "5.0.3",
"@sveltepress/theme-default": "^6.0.3",
"@sveltepress/twoslash": "^1.2.2",
"@sveltepress/vite": "^1.2.2",
"@testing-library/svelte": "^5.2.7",
"@testing-library/svelte": "^5.2.8",
"@testing-library/user-event": "^14.6.1",
"@types/d3-array": "^3.2.1",
"@types/d3-color": "^3.1.3",
Expand All @@ -77,9 +77,9 @@
"d3-dsv": "^3.0.1",
"d3-fetch": "^3.0.1",
"d3-force": "^3.0.0",
"eslint": "^9.26.0",
"eslint": "^9.27.0",
"eslint-config-prettier": "^10.1.5",
"eslint-plugin-svelte": "3.7.0",
"eslint-plugin-svelte": "3.9.0",
"jsdom": "^26.1.0",
"prettier": "^3.5.3",
"prettier-plugin-svelte": "^3.4.0",
Expand All @@ -97,7 +97,7 @@
"typedoc-plugin-markdown": "^4.6.3",
"typescript": "^5.8.3",
"vite": "^6.3.5",
"vitest": "^3.1.3",
"vitest": "^3.1.4",
"vitest-matchmedia-mock": "^2.0.3"
},
"types": "./dist/index.d.ts",
Expand All @@ -116,9 +116,9 @@
"d3-scale-chromatic": "^3.1.0",
"d3-shape": "^3.2.0",
"d3-time": "^3.1.0",
"es-toolkit": "^1.37.2",
"es-toolkit": "^1.38.0",
"fast-equals": "^5.2.2",
"merge-deep": "^3.0.3",
"svelte": "5.30.1"
"svelte": "5.33.2"
}
}
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy