fix: line chart grouping (resolves #45) #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gka
commented
May 26, 2025
- bump dependencies
- fix [BUG] Line chart connects points between different groups #45
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-67
# or install the specific version
npm install svelteplot@0.2.6-pr-67.0 |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-67
# or install the specific version
npm install svelteplot@0.2.6-pr-67.1 |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-67
# or install the specific version
npm install svelteplot@0.2.6-pr-67.2 |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the line chart grouping issue (resolves #45) and bumps some dependency versions.
- Adds a new test to ensure points from different groups are not connected.
- Updates line grouping logic in Line.svelte by removing extra point duplication for single-point groups.
- Updates various configuration files (package.json, VS Code settings, GitHub workflows) to improve project consistency.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/tests/line.test.ts | Adds a test to validate that points from different groups are not connected |
| src/routes/transforms/jitter/+page.md | Removes the detailed time interval documentation for temporal jittering |
| src/lib/marks/Line.svelte | Changes the grouping logic by removing the condition that duplicated single points |
| package.json | Bumps the typedoc dependency version |
| .vscode/settings.json | Adds formatting, linting, and extension configurations |
| .vscode/extensions.json | Introduces recommended VS Code extensions |
| .github/workflows/npm-prerelease.yml | Consolidates if conditions and updates registry URL quotes |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
src/routes/transforms/jitter/+page.md:76
- The removal of detailed time interval strings might confuse users. Consider adding a note explaining the updated supported formats.
- '1 day', '3 days', ... (removed)
src/lib/marks/Line.svelte:76
- Removing the condition that duplicates a single point changes how line paths are rendered. Please confirm that single-point groups are now handled as intended.
if (group.length === 1) { ... } (removed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.