feature: axis tick count #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-78
# or install the specific version
npm install svelteplot@0.2.8-pr-78.0 |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces user-configurable tick spacing and count for both X and Y axes, along with documentation, examples, and tests.
- Adds
tickCountandtickSpacingprops (exclusive) toAxisXandAxisYmarks, and wire up overrides in rendering logic - Augments unit tests for axis marks covering default ticks, custom values, count, spacing, and interval scenarios
- Updates documentation and example pages to surface the new options; adds
ts-essentialsdependency for the XOR type
Reviewed Changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/marks/AxisY.svelte | Added tickCount/tickSpacing props, interval override, updated autoTickCount logic |
| src/lib/marks/AxisX.svelte | Added tickCount/tickSpacing props and autoTickCount logic (missing interval support) |
| src/tests/axisY.test.ts | New tests for tickCount, tickSpacing, interval on Y axis |
| src/tests/axisX.test.ts | New tests for tickCount, tickSpacing, interval on X axis |
| src/tests/axisY.test.svelte | Svelte test wrapper for Y axis |
| src/tests/axisX.test.svelte | Svelte test wrapper for X axis |
| src/routes/marks/axis/+page.md | Documented new tickSpacing and tickCount options |
| src/routes/examples/axis/*.svelte | Added tick-spacing, tick-count, and tick-interval examples |
| package.json | Added ts-essentials dependency for XOR type |
| .vscode/settings.json | Adjusted ESLint fix-on-save configuration |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
src/tests/axisY.test.ts:74
- [nitpick] Duplicate test description
'tickSpacing'. Rename this second test to distinguish it (e.g.,'tickSpacing via scale options').
it('tickSpacing', () => {
.vscode/settings.json:5
- [nitpick] The
source.fixAll.eslintsetting should typically be a boolean or an explicit object configuration rather than the string"explicit"; consider reverting totrueor a valid ESLint config object to ensure fixes run on save.
"source.fixAll.eslint": "explicit"
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-78
# or install the specific version
npm install svelteplot@0.2.8-pr-78.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses the issue raised in #73 by adding the
tickCountandtickSpacingoptions to the AxisX and AxisY marks.Also adds unit tests and some more examples for axis options.