Merge branch '3.4' into 4.3

nicolas-grekas · nicolas-grekas · commit 08b664a43d64 · 2019-10-28T18:07:32.000+01:00
* 3.4:
  #30432 fix an error message
  fix paths to detect code owners
  [Validator] Ensure numeric subpaths do not cause errors on PHP 7.4
  Remove unused local variables in tests
  Make sure to collect child forms created on *_SET_DATA events
  do not render errors for checkboxes twice
diff --git a/Tests/Adapter/MaxIdLengthAdapterTest.php b/Tests/Adapter/MaxIdLengthAdapterTest.php
@@ -70,7 +70,7 @@ public function testTooLongNamespace()
     {
         $this->expectException('Symfony\Component\Cache\Exception\InvalidArgumentException');
         $this->expectExceptionMessage('Namespace must be 26 chars max, 40 given ("----------------------------------------")');
-        $cache = $this->getMockBuilder(MaxIdLengthAdapter::class)
+        $this->getMockBuilder(MaxIdLengthAdapter::class)
             ->setConstructorArgs([str_repeat('-', 40)])
             ->getMock();
     }

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ public function testTooLongNamespace()`
`70`	`70`	`{`
`71`	`71`	`$this->expectException('Symfony\Component\Cache\Exception\InvalidArgumentException');`
`72`	`72`	`$this->expectExceptionMessage('Namespace must be 26 chars max, 40 given ("----------------------------------------")');`
`73`		`- $cache = $this->getMockBuilder(MaxIdLengthAdapter::class)`
	`73`	`+ $this->getMockBuilder(MaxIdLengthAdapter::class)`
`74`	`74`	`->setConstructorArgs([str_repeat('-', 40)])`
`75`	`75`	`->getMock();`
`76`	`76`	`}`