feature #32446 [Lock] rename and deprecate Factory into LockFactory (Simperfit)

fabpot · fabpot · commit 0dc547d5db42 · 2019-07-09T08:22:23.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [Lock] rename and deprecate Factory into LockFactory | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no  | BC breaks? | no  | Deprecations? | yes | Tests pass? | yes  | Fixed tickets | none  | License | MIT | Doc PR   As highlighted in symfony/symfony#32198 (review) we need to rename the factory to LockFactory for consistency and readability. Commits ------- fc75eb9bef [Lock] rename and deprecate Factory into LockFactory
diff --git a/Command/LockableTrait.php b/Command/LockableTrait.php
@@ -12,8 +12,8 @@
 namespace Symfony\Component\Console\Command;
 
 use Symfony\Component\Console\Exception\LogicException;
-use Symfony\Component\Lock\Factory;
 use Symfony\Component\Lock\Lock;
+use Symfony\Component\Lock\LockFactory;
 use Symfony\Component\Lock\Store\FlockStore;
 use Symfony\Component\Lock\Store\SemaphoreStore;
 
@@ -48,7 +48,7 @@ private function lock($name = null, $blocking = false)
             $store = new FlockStore();
         }
 
-        $this->lock = (new Factory($store))->createLock($name ?: $this->getName());
+        $this->lock = (new LockFactory($store))->createLock($name ?: $this->getName());
         if (!$this->lock->acquire($blocking)) {
             $this->lock = null;
 
diff --git a/Tests/Command/LockableTraitTest.php b/Tests/Command/LockableTraitTest.php
@@ -13,7 +13,7 @@
 
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Console\Tester\CommandTester;
-use Symfony\Component\Lock\Factory;
+use Symfony\Component\Lock\LockFactory;
 use Symfony\Component\Lock\Store\FlockStore;
 use Symfony\Component\Lock\Store\SemaphoreStore;
 
@@ -47,7 +47,7 @@ public function testLockReturnsFalseIfAlreadyLockedByAnotherCommand()
             $store = new FlockStore();
         }
 
-        $lock = (new Factory($store))->createLock($command->getName());
+        $lock = (new LockFactory($store))->createLock($command->getName());
         $lock->acquire();
 
         $tester = new CommandTester($command);
