[Console] Allow false as a $shortcut in InputOption

jayminsilicon · nicolas-grekas · commit 37774e6b72ae · 2024-02-01T13:56:48.000+01:00
diff --git a/Input/InputOption.php b/Input/InputOption.php
@@ -69,7 +69,7 @@ public function __construct(string $name, $shortcut = null, ?int $mode = null, s
             throw new InvalidArgumentException('An option name cannot be empty.');
         }
 
-        if ('' === $shortcut || [] === $shortcut) {
+        if ('' === $shortcut || [] === $shortcut || false === $shortcut) {
             $shortcut = null;
         }
 
diff --git a/Tests/Input/InputOptionTest.php b/Tests/Input/InputOptionTest.php
@@ -69,6 +69,8 @@ public function testShortcut()
         $this->assertEquals('0|z', $option->getShortcut(), '-0 is an acceptable shortcut value when embedded in an array');
         $option = new InputOption('foo', '0|z');
         $this->assertEquals('0|z', $option->getShortcut(), '-0 is an acceptable shortcut value when embedded in a string-list');
+        $option = new InputOption('foo', false);
+        $this->assertNull($option->getShortcut(), '__construct() makes the shortcut null when given a false as value');
     }
 
     public function testModes()

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ public function __construct(string $name, $shortcut = null, ?int $mode = null, s`
`69`	`69`	`throw new InvalidArgumentException('An option name cannot be empty.');`
`70`	`70`	`}`
`71`	`71`
`72`		`- if ('' === $shortcut \|\| [] === $shortcut) {`
	`72`	`+ if ('' === $shortcut \|\| [] === $shortcut \|\| false === $shortcut) {`
`73`	`73`	`$shortcut = null;`
`74`	`74`	`}`
`75`	`75`
Original file line number	Diff line number	Diff line change
`@@ -69,6 +69,8 @@ public function testShortcut()`
`69`	`69`	`$this->assertEquals('0\|z', $option->getShortcut(), '-0 is an acceptable shortcut value when embedded in an array');`
`70`	`70`	`$option = new InputOption('foo', '0\|z');`
`71`	`71`	`$this->assertEquals('0\|z', $option->getShortcut(), '-0 is an acceptable shortcut value when embedded in a string-list');`
	`72`	`+ $option = new InputOption('foo', false);`
	`73`	`+ $this->assertNull($option->getShortcut(), '__construct() makes the shortcut null when given a false as value');`
`72`	`74`	`}`
`73`	`75`
`74`	`76`	`public function testModes()`