replace assertEmpty() with stricter assertions

xabbuh · xabbuh · commit 28d6dfa2bf46 · 2025-03-05T11:15:41.000+01:00
diff --git a/Tests/ParameterBagTest.php b/Tests/ParameterBagTest.php
@@ -253,7 +253,7 @@ public function testFilter()
             'array' => ['bang'],
         ]);
 
-        $this->assertEmpty($bag->filter('nokey'), '->filter() should return empty by default if no key is found');
+        $this->assertSame('', $bag->filter('nokey'), '->filter() should return empty by default if no key is found');
 
         $this->assertEquals('0123', $bag->filter('digits', '', \FILTER_SANITIZE_NUMBER_INT), '->filter() gets a value of parameter as integer filtering out invalid characters');
 
diff --git a/Tests/ResponseTest.php b/Tests/ResponseTest.php
@@ -127,7 +127,7 @@ public function testSetNotModified()
         ob_start();
         $modified->sendContent();
         $string = ob_get_clean();
-        $this->assertEmpty($string);
+        $this->assertSame('', $string);
     }
 
     public function testIsSuccessful()
diff --git a/Tests/Session/Storage/Handler/PdoSessionHandlerTest.php b/Tests/Session/Storage/Handler/PdoSessionHandlerTest.php
@@ -352,7 +352,7 @@ public function testConfigureSchemaTableExistsPdo()
         $pdoSessionHandler = new PdoSessionHandler($this->getMemorySqlitePdo());
         $pdoSessionHandler->configureSchema($schema, fn () => true);
         $table = $schema->getTable('sessions');
-        $this->assertEmpty($table->getColumns(), 'The table was not overwritten');
+        $this->assertSame([], $table->getColumns(), 'The table was not overwritten');
     }
 
     public static function provideUrlDsnPairs()
diff --git a/Tests/StreamedResponseTest.php b/Tests/StreamedResponseTest.php
@@ -133,7 +133,7 @@ public function testSetNotModified()
         ob_start();
         $modified->sendContent();
         $string = ob_get_clean();
-        $this->assertEmpty($string);
+        $this->assertSame('', $string);
     }
 
     public function testSendInformationalResponse()

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ public function testSetNotModified()`
`127`	`127`	`ob_start();`
`128`	`128`	`$modified->sendContent();`
`129`	`129`	`$string = ob_get_clean();`
`130`		`- $this->assertEmpty($string);`
	`130`	`+ $this->assertSame('', $string);`
`131`	`131`	`}`
`132`	`132`
`133`	`133`	`public function testIsSuccessful()`
Original file line number	Diff line number	Diff line change
`@@ -352,7 +352,7 @@ public function testConfigureSchemaTableExistsPdo()`
`352`	`352`	`$pdoSessionHandler = new PdoSessionHandler($this->getMemorySqlitePdo());`
`353`	`353`	`$pdoSessionHandler->configureSchema($schema, fn () => true);`
`354`	`354`	`$table = $schema->getTable('sessions');`
`355`		`- $this->assertEmpty($table->getColumns(), 'The table was not overwritten');`
	`355`	`+ $this->assertSame([], $table->getColumns(), 'The table was not overwritten');`
`356`	`356`	`}`
`357`	`357`
`358`	`358`	`public static function provideUrlDsnPairs()`
Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ public function testSetNotModified()`
`133`	`133`	`ob_start();`
`134`	`134`	`$modified->sendContent();`
`135`	`135`	`$string = ob_get_clean();`
`136`		`- $this->assertEmpty($string);`
	`136`	`+ $this->assertSame('', $string);`
`137`	`137`	`}`
`138`	`138`
`139`	`139`	`public function testSendInformationalResponse()`