optimize in_array calls

gharlan · nicolas-grekas · commit 50e06873a1f1 · 2025-07-15T11:40:20.000+02:00
diff --git a/HeaderUtils.php b/HeaderUtils.php
@@ -164,7 +164,7 @@ public static function unquote(string $s): string
      */
     public static function makeDisposition(string $disposition, string $filename, string $filenameFallback = ''): string
     {
-        if (!\in_array($disposition, [self::DISPOSITION_ATTACHMENT, self::DISPOSITION_INLINE])) {
+        if (!\in_array($disposition, [self::DISPOSITION_ATTACHMENT, self::DISPOSITION_INLINE], true)) {
             throw new \InvalidArgumentException(\sprintf('The disposition must be either "%s" or "%s".', self::DISPOSITION_ATTACHMENT, self::DISPOSITION_INLINE));
         }
 
diff --git a/Request.php b/Request.php
@@ -1351,15 +1351,15 @@ public function isMethod(string $method): bool
      */
     public function isMethodSafe(): bool
     {
-        return \in_array($this->getMethod(), ['GET', 'HEAD', 'OPTIONS', 'TRACE']);
+        return \in_array($this->getMethod(), ['GET', 'HEAD', 'OPTIONS', 'TRACE'], true);
     }
 
     /**
      * Checks whether or not the method is idempotent.
      */
     public function isMethodIdempotent(): bool
     {
-        return \in_array($this->getMethod(), ['HEAD', 'GET', 'PUT', 'DELETE', 'TRACE', 'OPTIONS', 'PURGE']);
+        return \in_array($this->getMethod(), ['HEAD', 'GET', 'PUT', 'DELETE', 'TRACE', 'OPTIONS', 'PURGE'], true);
     }
 
     /**
@@ -1369,7 +1369,7 @@ public function isMethodIdempotent(): bool
      */
     public function isMethodCacheable(): bool
     {
-        return \in_array($this->getMethod(), ['GET', 'HEAD']);
+        return \in_array($this->getMethod(), ['GET', 'HEAD'], true);
     }
 
     /**
diff --git a/Response.php b/Response.php
@@ -545,7 +545,7 @@ public function getCharset(): ?string
      */
     public function isCacheable(): bool
     {
-        if (!\in_array($this->statusCode, [200, 203, 300, 301, 302, 404, 410])) {
+        if (!\in_array($this->statusCode, [200, 203, 300, 301, 302, 404, 410], true)) {
             return false;
         }
 
@@ -1254,7 +1254,7 @@ public function isNotFound(): bool
      */
     public function isRedirect(?string $location = null): bool
     {
-        return \in_array($this->statusCode, [201, 301, 302, 303, 307, 308]) && (null === $location ?: $location == $this->headers->get('Location'));
+        return \in_array($this->statusCode, [201, 301, 302, 303, 307, 308], true) && (null === $location ?: $location == $this->headers->get('Location'));
     }
 
     /**
@@ -1264,7 +1264,7 @@ public function isRedirect(?string $location = null): bool
      */
     public function isEmpty(): bool
     {
-        return \in_array($this->statusCode, [204, 304]);
+        return \in_array($this->statusCode, [204, 304], true);
     }
 
     /**
diff --git a/ResponseHeaderBag.php b/ResponseHeaderBag.php
@@ -194,7 +194,7 @@ public function removeCookie(string $name, ?string $path = '/', ?string $domain
      */
     public function getCookies(string $format = self::COOKIES_FLAT): array
     {
-        if (!\in_array($format, [self::COOKIES_FLAT, self::COOKIES_ARRAY])) {
+        if (!\in_array($format, [self::COOKIES_FLAT, self::COOKIES_ARRAY], true)) {
             throw new \InvalidArgumentException(\sprintf('Format "%s" invalid (%s).', $format, implode(', ', [self::COOKIES_FLAT, self::COOKIES_ARRAY])));
         }
 

Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ public static function unquote(string $s): string`
`164`	`164`	`*/`
`165`	`165`	`public static function makeDisposition(string $disposition, string $filename, string $filenameFallback = ''): string`
`166`	`166`	`{`
`167`		`- if (!\in_array($disposition, [self::DISPOSITION_ATTACHMENT, self::DISPOSITION_INLINE])) {`
	`167`	`+ if (!\in_array($disposition, [self::DISPOSITION_ATTACHMENT, self::DISPOSITION_INLINE], true)) {`
`168`	`168`	`throw new \InvalidArgumentException(\sprintf('The disposition must be either "%s" or "%s".', self::DISPOSITION_ATTACHMENT, self::DISPOSITION_INLINE));`
`169`	`169`	`}`
`170`	`170`
Original file line number	Diff line number	Diff line change
`@@ -1351,15 +1351,15 @@ public function isMethod(string $method): bool`
`1351`	`1351`	`*/`
`1352`	`1352`	`public function isMethodSafe(): bool`
`1353`	`1353`	`{`
`1354`		`- return \in_array($this->getMethod(), ['GET', 'HEAD', 'OPTIONS', 'TRACE']);`
	`1354`	`+ return \in_array($this->getMethod(), ['GET', 'HEAD', 'OPTIONS', 'TRACE'], true);`
`1355`	`1355`	`}`
`1356`	`1356`
`1357`	`1357`	`/**`
`1358`	`1358`	`* Checks whether or not the method is idempotent.`
`1359`	`1359`	`*/`
`1360`	`1360`	`public function isMethodIdempotent(): bool`
`1361`	`1361`	`{`
`1362`		`- return \in_array($this->getMethod(), ['HEAD', 'GET', 'PUT', 'DELETE', 'TRACE', 'OPTIONS', 'PURGE']);`
	`1362`	`+ return \in_array($this->getMethod(), ['HEAD', 'GET', 'PUT', 'DELETE', 'TRACE', 'OPTIONS', 'PURGE'], true);`
`1363`	`1363`	`}`
`1364`	`1364`
`1365`	`1365`	`/**`
`@@ -1369,7 +1369,7 @@ public function isMethodIdempotent(): bool`
`1369`	`1369`	`*/`
`1370`	`1370`	`public function isMethodCacheable(): bool`
`1371`	`1371`	`{`
`1372`		`- return \in_array($this->getMethod(), ['GET', 'HEAD']);`
	`1372`	`+ return \in_array($this->getMethod(), ['GET', 'HEAD'], true);`
`1373`	`1373`	`}`
`1374`	`1374`
`1375`	`1375`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -545,7 +545,7 @@ public function getCharset(): ?string`
`545`	`545`	`*/`
`546`	`546`	`public function isCacheable(): bool`
`547`	`547`	`{`
`548`		`- if (!\in_array($this->statusCode, [200, 203, 300, 301, 302, 404, 410])) {`
	`548`	`+ if (!\in_array($this->statusCode, [200, 203, 300, 301, 302, 404, 410], true)) {`
`549`	`549`	`return false;`
`550`	`550`	`}`
`551`	`551`
`@@ -1254,7 +1254,7 @@ public function isNotFound(): bool`
`1254`	`1254`	`*/`
`1255`	`1255`	`public function isRedirect(?string $location = null): bool`
`1256`	`1256`	`{`
`1257`		`- return \in_array($this->statusCode, [201, 301, 302, 303, 307, 308]) && (null === $location ?: $location == $this->headers->get('Location'));`
	`1257`	`+ return \in_array($this->statusCode, [201, 301, 302, 303, 307, 308], true) && (null === $location ?: $location == $this->headers->get('Location'));`
`1258`	`1258`	`}`
`1259`	`1259`
`1260`	`1260`	`/**`
`@@ -1264,7 +1264,7 @@ public function isRedirect(?string $location = null): bool`
`1264`	`1264`	`*/`
`1265`	`1265`	`public function isEmpty(): bool`
`1266`	`1266`	`{`
`1267`		`- return \in_array($this->statusCode, [204, 304]);`
	`1267`	`+ return \in_array($this->statusCode, [204, 304], true);`
`1268`	`1268`	`}`
`1269`	`1269`
`1270`	`1270`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ public function removeCookie(string $name, ?string $path = '/', ?string $domain`
`194`	`194`	`*/`
`195`	`195`	`public function getCookies(string $format = self::COOKIES_FLAT): array`
`196`	`196`	`{`
`197`		`- if (!\in_array($format, [self::COOKIES_FLAT, self::COOKIES_ARRAY])) {`
	`197`	`+ if (!\in_array($format, [self::COOKIES_FLAT, self::COOKIES_ARRAY], true)) {`
`198`	`198`	`throw new \InvalidArgumentException(\sprintf('Format "%s" invalid (%s).', $format, implode(', ', [self::COOKIES_FLAT, self::COOKIES_ARRAY])));`
`199`	`199`	`}`
`200`	`200`