[MimeType] Duplicated MimeType due to PHP Bug

juanmrad · nicolas-grekas · commit cd70a529aeb6 · 2020-06-28T16:49:36.000+02:00
diff --git a/File/MimeType/FileinfoMimeTypeGuesser.php b/File/MimeType/FileinfoMimeTypeGuesser.php
@@ -63,7 +63,13 @@ public function guess($path)
         if (!$finfo = new \finfo(FILEINFO_MIME_TYPE, $this->magicFile)) {
             return null;
         }
+        $mimeType = $finfo->file($path);
 
-        return $finfo->file($path);
+        if ($mimeType && 0 === (\strlen($mimeType) % 2)) {
+            $mimeStart = substr($mimeType, 0, \strlen($mimeType) >> 1);
+            $mimeType = $mimeStart.$mimeStart === $mimeType ? $mimeStart : $mimeType;
+        }
+
+        return $mimeType;
     }
 }
diff --git a/Tests/File/Fixtures/test.docx b/Tests/File/Fixtures/test.docx
diff --git a/Tests/File/MimeType/MimeTypeTest.php b/Tests/File/MimeType/MimeTypeTest.php
@@ -60,6 +60,14 @@ public function testGuessFileWithUnknownExtension()
         $this->assertEquals('application/octet-stream', MimeTypeGuesser::getInstance()->guess(__DIR__.'/../Fixtures/.unknownextension'));
     }
 
+    /**
+     * @requires PHP 7.0
+     */
+    public function testGuessWithDuplicatedFileType()
+    {
+        $this->assertEquals('application/vnd.openxmlformats-officedocument.wordprocessingml.document', MimeTypeGuesser::getInstance()->guess(__DIR__.'/../Fixtures/test.docx'));
+    }
+
     public function testGuessWithIncorrectPath()
     {
         $this->expectException('Symfony\Component\HttpFoundation\File\Exception\FileNotFoundException');

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,13 @@ public function guess($path)`
`63`	`63`	`if (!$finfo = new \finfo(FILEINFO_MIME_TYPE, $this->magicFile)) {`
`64`	`64`	`return null;`
`65`	`65`	`}`
	`66`	`+ $mimeType = $finfo->file($path);`
`66`	`67`
`67`		`- return $finfo->file($path);`
	`68`	`+ if ($mimeType && 0 === (\strlen($mimeType) % 2)) {`
	`69`	`+ $mimeStart = substr($mimeType, 0, \strlen($mimeType) >> 1);`
	`70`	`+ $mimeType = $mimeStart.$mimeStart === $mimeType ? $mimeStart : $mimeType;`
	`71`	`+ }`
	`72`	`+`
	`73`	`+ return $mimeType;`
`68`	`74`	`}`
`69`	`75`	`}`
Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,14 @@ public function testGuessFileWithUnknownExtension()`
`60`	`60`	`$this->assertEquals('application/octet-stream', MimeTypeGuesser::getInstance()->guess(__DIR__.'/../Fixtures/.unknownextension'));`
`61`	`61`	`}`
`62`	`62`
	`63`	`+ /**`
	`64`	`+ * @requires PHP 7.0`
	`65`	`+ */`
	`66`	`+ public function testGuessWithDuplicatedFileType()`
	`67`	`+ {`
	`68`	`+ $this->assertEquals('application/vnd.openxmlformats-officedocument.wordprocessingml.document', MimeTypeGuesser::getInstance()->guess(__DIR__.'/../Fixtures/test.docx'));`
	`69`	`+ }`
	`70`	`+`
`63`	`71`	`public function testGuessWithIncorrectPath()`
`64`	`72`	`{`
`65`	`73`	`$this->expectException('Symfony\Component\HttpFoundation\File\Exception\FileNotFoundException');`