minor #61112 [HttpKernel][Security] Refactor: use getAttributes with argument (santysisi)

nicolas-grekas · nicolas-grekas · commit b70e37fc61bb · 2025-07-15T13:27:43.000+02:00
This PR was merged into the 7.4 branch. Discussion ---------- [HttpKernel][Security] Refactor: use `getAttributes` with argument | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | no | License | MIT Refactored code to consistently use `$event->getAttributes($className)` instead of accessing the full array. This simplifies attribute retrieval and improves readability. [Reference](symfony/symfony#60395 (comment)) Commits ------- 6769c9a8287 [HttpKernel][Security] Refactor: use `getAttributes` with argument
diff --git a/EventListener/CacheAttributeListener.php b/EventListener/CacheAttributeListener.php
@@ -51,7 +51,7 @@ public function onKernelControllerArguments(ControllerArgumentsEvent $event): vo
     {
         $request = $event->getRequest();
 
-        if (!\is_array($attributes = $request->attributes->get('_cache') ?? $event->getAttributes()[Cache::class] ?? null)) {
+        if (!$attributes = $request->attributes->get('_cache') ?? $event->getAttributes(Cache::class)) {
             return;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public function onKernelControllerArguments(ControllerArgumentsEvent $event): vo`
`51`	`51`	`{`
`52`	`52`	`$request = $event->getRequest();`
`53`	`53`
`54`		`- if (!\is_array($attributes = $request->attributes->get('_cache') ?? $event->getAttributes()[Cache::class] ?? null)) {`
	`54`	`+ if (!$attributes = $request->attributes->get('_cache') ?? $event->getAttributes(Cache::class)) {`
`55`	`55`	`return;`
`56`	`56`	`}`
`57`	`57`