feature #54859 [Messenger] Don't mark EnvelopeAwareExceptionInterface internal (valtzu)

fabpot · fabpot · commit f73c85615ae8 · 2024-05-07T14:12:00.000+02:00
This PR was merged into the 7.1 branch. Discussion ---------- [Messenger] Don't mark `EnvelopeAwareExceptionInterface` internal | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | License | MIT As discussed [here](symfony/symfony#54842 (comment)), let's expose `EnvelopeAwareExceptionInterface` to allow custom Messenger middlewares throw a custom exception without causing stamps from previous middlewares being dropped. Commits ------- 7713fd17f5 Don't mark EnvelopeAwareExceptionInterface internal
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@ CHANGELOG
  * Add `--all` option to the `messenger:consume` command
  * Add parameter `$jitter` to `MultiplierRetryStrategy` in order to randomize delay and prevent the thundering herd effect
  * Add `SIGQUIT` signal among list of signals that gracefully shut down `messenger:consume` and `messenger:failed:retry` commands
+ * Add `EnvelopeAwareExceptionInterface` for exceptions thrown from middlewares to prevent stamps added by previous middlewares being dropped
 
 7.0
 ---
diff --git a/Exception/EnvelopeAwareExceptionInterface.php b/Exception/EnvelopeAwareExceptionInterface.php
@@ -13,9 +13,6 @@
 
 use Symfony\Component\Messenger\Envelope;
 
-/**
- * @internal
- */
 interface EnvelopeAwareExceptionInterface
 {
     public function getEnvelope(): ?Envelope;

Original file line number	Diff line number	Diff line change
`@@ -13,9 +13,6 @@`
`13`	`13`
`14`	`14`	`use Symfony\Component\Messenger\Envelope;`
`15`	`15`
`16`		`-/**`
`17`		`- * @internal`
`18`		`- */`
`19`	`16`	`interface EnvelopeAwareExceptionInterface`
`20`	`17`	`{`
`21`	`18`	`public function getEnvelope(): ?Envelope;`