bug #41961 [Serializer] Need to clear cache when updating Annotation Groups on Entities (monteiro)

fabpot · fabpot · commit 018b1094387e · 2021-07-04T10:59:30.000+02:00
This PR was squashed before being merged into the 5.3 branch. Discussion ---------- [Serializer] Need to clear cache when updating Annotation Groups on Entities | Q | A | ------------- | --- | Branch? | 5.3  | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | Fix #40034  | License | MIT Sample project that mimics this behavior: https://github.com/monteiro/PR-40856 The solution was suggested by `@nicolas`-grekas [here](#40856). Commits ------- a6829be [Serializer] Need to clear cache when updating Annotation Groups on Entities
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -1705,6 +1705,9 @@ private function registerSecurityCsrfConfiguration(array $config, ContainerBuild
     private function registerSerializerConfiguration(array $config, ContainerBuilder $container, PhpFileLoader $loader)
     {
         $loader->load('serializer.php');
+        if ($container->getParameter('kernel.debug')) {
+            $container->removeDefinition('serializer.mapping.cache_class_metadata_factory');
+        }
 
         $chainLoader = $container->getDefinition('serializer.mapping.chain_loader');
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
@@ -1400,10 +1400,10 @@ public function testSerializerCacheActivated()
         $this->assertEquals(new Reference('serializer.mapping.cache.symfony'), $cache);
     }
 
-    public function testSerializerCacheActivatedDebug()
+    public function testSerializerCacheNotActivatedDebug()
     {
         $container = $this->createContainerFromFile('serializer_enabled', ['kernel.debug' => true, 'kernel.container_class' => __CLASS__]);
-        $this->assertTrue($container->hasDefinition('serializer.mapping.cache_class_metadata_factory'));
+        $this->assertFalse($container->hasDefinition('serializer.mapping.cache_class_metadata_factory'));
     }
 
     public function testSerializerMapping()

Original file line number	Diff line number	Diff line change
`@@ -1705,6 +1705,9 @@ private function registerSecurityCsrfConfiguration(array $config, ContainerBuild`
`1705`	`1705`	`private function registerSerializerConfiguration(array $config, ContainerBuilder $container, PhpFileLoader $loader)`
`1706`	`1706`	`{`
`1707`	`1707`	`$loader->load('serializer.php');`
	`1708`	`+ if ($container->getParameter('kernel.debug')) {`
	`1709`	`+ $container->removeDefinition('serializer.mapping.cache_class_metadata_factory');`
	`1710`	`+ }`
`1708`	`1711`
`1709`	`1712`	`$chainLoader = $container->getDefinition('serializer.mapping.chain_loader');`
`1710`	`1713`
Original file line number	Diff line number	Diff line change
`@@ -1400,10 +1400,10 @@ public function testSerializerCacheActivated()`
`1400`	`1400`	`$this->assertEquals(new Reference('serializer.mapping.cache.symfony'), $cache);`
`1401`	`1401`	`}`
`1402`	`1402`
`1403`		`- public function testSerializerCacheActivatedDebug()`
	`1403`	`+ public function testSerializerCacheNotActivatedDebug()`
`1404`	`1404`	`{`
`1405`	`1405`	`$container = $this->createContainerFromFile('serializer_enabled', ['kernel.debug' => true, 'kernel.container_class' => __CLASS__]);`
`1406`		`- $this->assertTrue($container->hasDefinition('serializer.mapping.cache_class_metadata_factory'));`
	`1406`	`+ $this->assertFalse($container->hasDefinition('serializer.mapping.cache_class_metadata_factory'));`
`1407`	`1407`	`}`
`1408`	`1408`
`1409`	`1409`	`public function testSerializerMapping()`