add back setAccessible() for PHP 7 compatibility

xabbuh · xabbuh · commit 0270060cfe6d · 2025-07-24T13:44:59.000+02:00
diff --git a/src/Symfony/Bridge/PhpUnit/CoverageListener.php b/src/Symfony/Bridge/PhpUnit/CoverageListener.php
@@ -86,6 +86,7 @@ public function startTest(Test $test): void
     private function addCoversForClassToAnnotationCache(Test $test, array $covers): void
     {
         $r = new \ReflectionProperty(TestUtil::class, 'annotationCache');
+        $r->setAccessible(true);
 
         $cache = $r->getValue();
         $cache = array_replace_recursive($cache, [
@@ -102,6 +103,7 @@ private function addCoversForDocBlockInsideRegistry(Test $test, array $covers):
         $docBlock = Registry::getInstance()->forClassName(\get_class($test));
 
         $symbolAnnotations = new \ReflectionProperty($docBlock, 'symbolAnnotations');
+        $symbolAnnotations->setAccessible(true);
 
         // Exclude internal classes; PHPUnit 9.1+ is picky about tests covering, say, a \RuntimeException
         $covers = array_filter($covers, function (string $class) {
diff --git a/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Deprecation.php b/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Deprecation.php
@@ -437,6 +437,7 @@ public function toString()
     {
         $exception = new \Exception($this->message);
         $reflection = new \ReflectionProperty($exception, 'trace');
+        $reflection->setAccessible(true);
         $reflection->setValue($exception, $this->trace);
 
         return ($this->originatesFromAnObject() ? 'deprecation triggered by '.$this->originatingClass().'::'.$this->originatingMethod().":\n" : '')
diff --git a/src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php b/src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php
@@ -357,6 +357,7 @@ private function willBeIsolated(TestCase $test): bool
         }
 
         $r = new \ReflectionProperty($test, 'runTestInSeparateProcess');
+        $r->setAccessible(true);
 
         return $r->getValue($test) ?? false;
     }
diff --git a/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationTest.php b/src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationTest.php
@@ -275,6 +275,7 @@ public static function setUpBeforeClass(): void
                     $loader = require $v.'/autoload.php';
                     $reflection = new \ReflectionClass($loader);
                     $prop = $reflection->getProperty('prefixDirsPsr4');
+                    $prop->setAccessible(true);
                     $currentValue = $prop->getValue($loader);
                     self::$prefixDirsPsr4[] = [$prop, $loader, $currentValue];
                     $currentValue['Symfony\\Bridge\\PhpUnit\\'] = [realpath(__DIR__.'/../..')];

Original file line number	Diff line number	Diff line change
`@@ -437,6 +437,7 @@ public function toString()`
`437`	`437`	`{`
`438`	`438`	`$exception = new \Exception($this->message);`
`439`	`439`	`$reflection = new \ReflectionProperty($exception, 'trace');`
	`440`	`+ $reflection->setAccessible(true);`
`440`	`441`	`$reflection->setValue($exception, $this->trace);`
`441`	`442`
`442`	`443`	`return ($this->originatesFromAnObject() ? 'deprecation triggered by '.$this->originatingClass().'::'.$this->originatingMethod().":\n" : '')`
Original file line number	Diff line number	Diff line change
`@@ -357,6 +357,7 @@ private function willBeIsolated(TestCase $test): bool`
`357`	`357`	`}`
`358`	`358`
`359`	`359`	`$r = new \ReflectionProperty($test, 'runTestInSeparateProcess');`
	`360`	`+ $r->setAccessible(true);`
`360`	`361`
`361`	`362`	`return $r->getValue($test) ?? false;`
`362`	`363`	`}`